Merge pull request #553 from samsonasik/use-structarmed-on-qa

Use StructArmed on QA

Author: arhimede

composer.json

@@ -83,6 +83,7 @@
         "zircote/swagger-php": "^6.0.0"
     },
     "require-dev": {
+        "boundwize/structarmed": "^0.17.12",
         "dotkernel/dot-maker": "^2.0.0",
         "laminas/laminas-coding-standard": "^3.0.1",
         "laminas/laminas-development-mode": "^3.13.0",

src/App/src/Factory/ProblemDetailsDelegatorFactory.php

@@ -41,7 +41,7 @@ public function __invoke(
         $errorHandler = $container->get(ErrorHandlerInterface::class);
         assert($errorHandler instanceof LogErrorHandler);
 
-        $listener = function (Throwable $throwable, RequestInterface $request) use ($errorHandler) {
+        $listener = static function (Throwable $throwable, RequestInterface $request) use ($errorHandler) {
             assert($request instanceof ServerRequestInterface);
             $errorHandler->handleThrowable($throwable, $request);
         };

src/App/src/Factory/UserIdentityFactory.php

@@ -12,7 +12,7 @@ class UserIdentityFactory
 {
     public function __invoke(ContainerInterface $container): callable
     {
-        return function (string $identity, array $roles = [], array $details = []): UserInterface {
+        return static function (string $identity, array $roles = [], array $details = []): UserInterface {
             /** @var non-empty-string $identity */
             return new UserIdentity($identity, $roles, $details);
         };

src/App/src/Middleware/AuthorizationMiddleware.php

@@ -75,7 +75,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
         }
 
         $defaultUser->setRoles(
-            array_map(fn (RoleInterface $role): string => (string) $role->getName()->value, $user->getRoles())
+            array_map(static fn (RoleInterface $role): string => (string) $role->getName()->value, $user->getRoles())
         );
 
         $request = $request->withAttribute(UserInterface::class, $defaultUser);

src/App/src/Middleware/ContentNegotiationMiddleware.php

@@ -128,7 +128,7 @@ private function parseAcceptHeader(string $header): array
         }
 
         // Sort by quality in descending order
-        usort($types, fn ($a, $b) => $b['quality'] <=> $a['quality']);
+        usort($types, static fn ($a, $b) => $b['quality'] <=> $a['quality']);
 
         return $types;
     }

src/App/src/Middleware/DeprecationMiddleware.php

@@ -86,7 +86,8 @@ private function getAttribute(array $attributes): ?array
         return array_values(
             array_filter(
                 $attributes,
-                fn (array $attribute): bool => $attribute['deprecationType'] === self::RESOURCE_DEPRECATION_ATTRIBUTE
+                static fn (array $attribute): bool
+                => $attribute['deprecationType'] === self::RESOURCE_DEPRECATION_ATTRIBUTE
             )
         )[0] ?? null;
     }

src/Core/src/Admin/src/Entity/Admin.php

@@ -241,7 +241,10 @@ public function getArrayCopy(): array
             'firstName' => $this->firstName,
             'lastName'  => $this->lastName,
             'status'    => $this->status->value,
-            'roles'     => array_map(fn (RoleInterface $role): array => $role->getArrayCopy(), $this->roles->toArray()),
+            'roles'     => array_map(
+                static fn (RoleInterface $role): array => $role->getArrayCopy(),
+                $this->roles->toArray()
+            ),
             'created'   => $this->created,
             'updated'   => $this->updated,
         ];

src/Core/src/Admin/src/Enum/AdminStatusEnum.php

@@ -25,7 +25,7 @@ public static function values(): array
      */
     public static function toArray(): array
     {
-        return array_reduce(self::cases(), function (array $collector, self $enum): array {
+        return array_reduce(self::cases(), static function (array $collector, self $enum): array {
             $collector[$enum->value] = $enum->name;
 
             return $collector;

src/Core/src/App/src/DBAL/Types/AbstractEnumType.php

@@ -26,7 +26,7 @@ public function getSQLDeclaration(array $column, AbstractPlatform $platform): st
             return 'TEXT';
         }
 
-        $values = array_map(fn($case) => "'$case->value'", $this->getEnumCases());
+        $values = array_map(static fn($case) => "'$case->value'", $this->getEnumCases());
 
         return sprintf('ENUM(%s)', implode(', ', $values));
     }

src/Core/src/User/src/Entity/User.php

@@ -361,7 +361,10 @@ public function getArrayCopy(): array
             'hash'     => $this->hash,
             'identity' => $this->identity,
             'status'   => $this->status->value,
-            'roles'    => array_map(fn (RoleInterface $role): array => $role->getArrayCopy(), $this->roles->toArray()),
+            'roles'    => array_map(
+                static fn (RoleInterface $role): array => $role->getArrayCopy(),
+                $this->roles->toArray()
+            ),
             'created'  => $this->created,
             'updated'  => $this->updated,
         ];