Merge pull request #537 from dotkernel/issue-535

Issue #535: Added class constant type declarations

Author: arhimede

phpcs.xml

@@ -24,4 +24,5 @@
         <exclude name="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly.ReferenceViaFullyQualifiedName" />
         <exclude-pattern>src/Core/src/App/src/Migration/*</exclude-pattern>
     </rule>
+    <rule ref="SlevomatCodingStandard.TypeHints.ClassConstantTypeHint"/>
 </ruleset>

src/App/src/InputFilter/Input/EmailInput.php

@@ -14,7 +14,7 @@
 
 class EmailInput extends Input
 {
-    public const EMAIL_MAX_LENGTH = 191;
+    public const int EMAIL_MAX_LENGTH = 191;
 
     public function __construct(?string $name = null, bool $isRequired = true)
     {

src/App/src/InputFilter/Input/FirstNameInput.php

@@ -13,7 +13,7 @@
 
 class FirstNameInput extends Input
 {
-    public const FIRSTNAME_MAX_LENGTH = 191;
+    public const int FIRSTNAME_MAX_LENGTH = 191;
 
     public function __construct(?string $name = null, bool $isRequired = true)
     {

src/App/src/InputFilter/Input/IdentityInput.php

@@ -13,8 +13,8 @@
 
 class IdentityInput extends Input
 {
-    public const IDENTITY_MIN_LENGTH = 3;
-    public const IDENTITY_MAX_LENGTH = 100;
+    public const int IDENTITY_MIN_LENGTH = 3;
+    public const int IDENTITY_MAX_LENGTH = 100;
 
     public function __construct(?string $name = null, bool $isRequired = true)
     {

src/App/src/InputFilter/Input/LastNameInput.php

@@ -13,7 +13,7 @@
 
 class LastNameInput extends Input
 {
-    public const LASTNAME_MAX_LENGTH = 191;
+    public const int LASTNAME_MAX_LENGTH = 191;
 
     public function __construct(?string $name = null, bool $isRequired = true)
     {

src/App/src/InputFilter/Input/PasswordInput.php

@@ -13,8 +13,8 @@
 
 class PasswordInput extends Input
 {
-    public const PASSWORD_MIN_LENGTH = 8;
-    public const PASSWORD_MAX_LENGTH = 150;
+    public const int PASSWORD_MIN_LENGTH = 8;
+    public const int PASSWORD_MAX_LENGTH = 150;
 
     public function __construct(?string $name = null, bool $isRequired = true)
     {

src/App/src/Middleware/ContentNegotiationMiddleware.php

@@ -31,7 +31,7 @@
 
 class ContentNegotiationMiddleware implements MiddlewareInterface
 {
-    public const DEFAULT_HEADERS = 'default';
+    public const string DEFAULT_HEADERS = 'default';
 
     /**
      * @param array<non-empty-string, mixed> $config

src/App/src/Middleware/DeprecationMiddleware.php

@@ -25,7 +25,7 @@
 
 class DeprecationMiddleware implements MiddlewareInterface
 {
-    public const RESOURCE_DEPRECATION_ATTRIBUTE = ResourceDeprecation::class;
+    public const string RESOURCE_DEPRECATION_ATTRIBUTE = ResourceDeprecation::class;
 
     /**
      * @param array<non-empty-string, mixed> $config

src/App/src/Service/ErrorReportService.php

@@ -27,7 +27,7 @@
 
 class ErrorReportService implements ErrorReportServiceInterface
 {
-    private const HEADER_NAME = 'Error-Reporting-Token';
+    private const string HEADER_NAME = 'Error-Reporting-Token';
 
     private Filesystem $fileSystem;
     private ?string $token = null;

src/Core/src/Admin/src/DBAL/Types/AdminRoleEnumType.php

@@ -9,7 +9,7 @@
 
 class AdminRoleEnumType extends AbstractEnumType
 {
-    public const NAME = 'admin_role_enum';
+    public const string NAME = 'admin_role_enum';
 
     public function getEnumClass(): string
     {