test and static-analysis fix

Author: OStefan2001

src/App/src/Handler/PostCreateContactHandler.php

@@ -20,6 +20,9 @@
 
 class PostCreateContactHandler implements RequestHandlerInterface
 {
+    /**
+     * @param array{check_proxy_headers: bool, trusted_proxies: array<non-empty-string>, attribute_name: non-empty-string, headers_to_inspect: array<non-empty-string>} $ipAddressConfig
+     */
     #[Inject(
         TemplateRendererInterface::class,
         UrlHelper::class,

test/Unit/App/Handler/PostCreateContactHandlerTest.php

@@ -26,6 +26,24 @@
 
 class PostCreateContactHandlerTest extends TestCase
 {
+    /**
+     * @return array{
+     *     check_proxy_headers: bool,
+     *     trusted_proxies: array<non-empty-string>,
+     *     attribute_name: non-empty-string,
+     *     headers_to_inspect: array<non-empty-string>,
+     * }
+     */
+    private function ipAddressConfig(): array
+    {
+        return [
+            'check_proxy_headers' => false,
+            'trusted_proxies'     => [],
+            'attribute_name'      => 'ip_address',
+            'headers_to_inspect'  => [],
+        ];
+    }
+
     /**
      * @return array<string, string>
      */
@@ -74,7 +92,12 @@ public function testValidSubmissionRedirectsOnSuccess(): void
             ->with('app::create-contact-form', [], ['contact' => 'sent'], 'contact-form')
             ->willReturn('/contact/?contact=sent#contact-form');
 
-        $handler  = new PostCreateContactHandler($template, $urlHelper, $this->service(new MailResult(true)));
+        $handler  = new PostCreateContactHandler(
+            $template,
+            $urlHelper,
+            $this->service(new MailResult(true)),
+            $this->ipAddressConfig()
+        );
         $response = $handler->handle($request);
 
         $this->assertInstanceOf(RedirectResponse::class, $response);
@@ -113,7 +136,8 @@ public function testMissingRequiredFieldsRerendersWithErrors(): void
         $handler  = new PostCreateContactHandler(
             $template,
             $this->createStub(UrlHelper::class),
-            $this->service(new MailResult(true))
+            $this->service(new MailResult(true)),
+            $this->ipAddressConfig()
         );
         $response = $handler->handle($request);
 
@@ -150,7 +174,8 @@ public function testRerenderKeepsAnyExtraQueryParamsAsDynamicHiddenFields(): voi
         $handler = new PostCreateContactHandler(
             $template,
             $this->createStub(UrlHelper::class),
-            $this->service(new MailResult(true))
+            $this->service(new MailResult(true)),
+            $this->ipAddressConfig()
         );
         $handler->handle($request);
     }
@@ -179,7 +204,8 @@ public function testMailTransportFailureRerendersWithMailFailedFlag(): void
         $handler  = new PostCreateContactHandler(
             $template,
             $this->createStub(UrlHelper::class),
-            $this->service(new RuntimeException('SMTP connection refused'))
+            $this->service(new RuntimeException('SMTP connection refused')),
+            $this->ipAddressConfig()
         );
         $response = $handler->handle($request);
 
@@ -232,7 +258,12 @@ public function testFailedTurnstileRerendersWithCaptchaErrorAndSendsNothing(): v
             )
             ->willReturn('<html></html>');
 
-        $handler  = new PostCreateContactHandler($template, $this->createStub(UrlHelper::class), $contactService);
+        $handler  = new PostCreateContactHandler(
+            $template,
+            $this->createStub(UrlHelper::class),
+            $contactService,
+            $this->ipAddressConfig()
+        );
         $response = $handler->handle($request);
 
         $this->assertInstanceOf(HtmlResponse::class, $response);
@@ -272,7 +303,8 @@ public function testValidSubmissionSendsTheIpAddressFromTheRequestAttribute(): v
         $response = (new PostCreateContactHandler(
             $this->createStub(TemplateRendererInterface::class),
             $urlHelper,
-            $contactService
+            $contactService,
+            $this->ipAddressConfig()
         ))->handle($request);
 
         $this->assertInstanceOf(RedirectResponse::class, $response);