Skip to content

Document EF Core breaking changes and SaveChanges interceptor outcomes - #5485

Merged
cincuranet merged 4 commits into
mainfrom
copilot/fix-issues-4890-4999-4852
Oct 16, 2026
Merged

cincuranet merged 4 commits into
mainfrom
copilot/fix-issues-4890-4999-4852

Conversation

Copilot AI commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #4890
Fixes #4999
Fixes #4852

Several EF Core breaking changes and ISaveChangesInterceptor callback semantics were undocumented or misleading.

  • EF Core 9 breaking changes

    • Document primitive collection API replacements.
    • Document SQL Server IndexOf null propagation and mitigation.
  • SaveChanges interception

    • Clarify callbacks for failures, cancellations, and concurrency conflicts.
    • Update the auditing sample to record each outcome through the appropriate interceptor callback.
var indexes = context.Entities.Select(
    e => e.NullableString == null
        ? 0
        : e.NullableString.IndexOf(string.Empty));

Copilot AI and others added 2 commits August 19, 2026 01:34
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Comment thread entity-framework/core/logging-events-diagnostics/interceptors.md Outdated
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot AI requested a review from AndriySvyryd October 15, 2026 20:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Correct the interceptor version history and complete the primitive collection replacement guidance.

1 open finding
What changed in this PR

Documents EF Core 9 breaking changes and clarifies ISaveChangesInterceptor outcomes.

Changes:

  • Documents primitive collection API replacements and SQL Server IndexOf behavior.
  • Updates auditing callbacks for failures, cancellations, and concurrency conflicts.
  • Clarifies interceptor callback semantics.
File Description
samples/​core/​Miscellaneous/​SaveChangesInterception/​AuditingInterceptor.cs Records failure, cancellation, and concurrency outcomes.
entity-framework/​core/​what-is-new/​ef-core-9.0/​breaking-changes.md Documents EF Core 9 breaking changes.
entity-framework/​core/​logging-events-diagnostics/​interceptors.md Clarifies SaveChanges callback semantics and examples.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread entity-framework/core/what-is-new/ef-core-9.0/breaking-changes.md Outdated
Updated breaking changes documentation for EF Core 9.0 to reflect API changes from EF Core 8.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@AndriySvyryd
AndriySvyryd marked this pull request as ready for review October 15, 2026 20:18
@AndriySvyryd
AndriySvyryd requested review from cincuranet and a lite review from Copilot October 15, 2026 20:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Preserve inner exception messages in the auditing sample and clarify nullable element-type guidance.

0 open findings

1 resolved since last review

🧠 Review effort: Lite

@cincuranet
cincuranet merged commit d74e5b4 into main Oct 16, 2026
7 checks passed
@cincuranet
cincuranet deleted the copilot/fix-issues-4890-4999-4852 branch October 16, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants