Skip to content

Commit dcfa720

Browse files
Milos KotlarCopilot
andcommitted
Address code review feedback
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 93a1281 commit dcfa720

7 files changed

Lines changed: 85 additions & 98 deletions

‎.github/workflows/code-review.agent.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ Review PR #${{ github.event.pull_request.number }} and post one comment using th
6464
| `src/TorchSharp/PInvoke/**` | `[DllImport]` signature mismatch with the C++ shim. Marshalling correctness (`IntPtr` vs `byte*`, `bool` blittability). |
6565
| `src/TorchSharp/Tensor/**` | Tensor ownership / `IDisposable` correctness. Any new `tensor` allocation must either be returned, disposed, or wrapped in a `using`. |
6666
| `src/TorchSharp/NN/**` | Module subclasses must call `RegisterComponents()` if they hold submodules or parameters. |
67-
| `pkg/**`, `Directory.Packages.props`, `Directory.Build.props` | Packaging changes. Flag any version bump that crosses a libtorch major; flag changes to `TorchSharp-cpu` / `TorchSharp-cuda-*` package layouts. |
68-
| `src/TorchVision/**`, `src/TorchAudio/**` | New transforms must have unit tests in `test/TorchSharpTest` or `test/TorchVisionTest`. |
67+
| `pkg/**`, `build/Dependencies.props`, `Directory.Build.props` | Packaging changes. Flag any version bump that crosses a libtorch major; flag changes to `TorchSharp-cpu` / `TorchSharp-cuda-*` package layouts. |
68+
| `src/TorchVision/**`, `src/TorchAudio/**` | New transforms must have unit tests in `test/TorchSharpTest`. |
6969
| `test/**` | Missing assertions, missing dispose, missing edge cases (empty tensor, CPU vs CUDA, dtype mismatch). |
7070

7171
## Process

‎.github/workflows/libtorch-bump.agent.lock.yml‎

Lines changed: 19 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)