Repository navigation
Conversation
wteja
requested review from
a team,
Youssef1313,
cincuranet,
davpetr and
rokonec
as code owners
October 23, 2026 04:40
Contributor
|
Thanks for your PR, @wteja. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
wteja
marked this pull request as draft
October 23, 2026 05:11
Author
|
@dotnet-policy-service agree |
wteja
marked this pull request as ready for review
October 23, 2026 14:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit required properties for MVC
[FromForm]complex models.Summary of the changes (Less than 80 chars)
Description
Populate form-schema
requiredlists from MVC binding and property validation metadata. Handle both a single form model and grouped schemas when additional form parameters are present, preserving explicitly renamed form fields.Add regression coverage for
[BindRequired],[Required], a required container parameter, the renamedfile_uploadfield, and optional scalar and nullable properties. Update controller snapshots for OpenAPI 3.0, 3.1, and 3.2, plus the localization snapshot.Fixes #69943
Testing
Validated on macOS arm64 with the repository SDK
12.0.100-alpha.1.26521.103:requiredlist.Microsoft.AspNetCore.OpenApi.Testsproject: 1,036 passed, 5 existing skips, 0 failed. Includes all 63 document snapshot cases and the localization snapshot.Microsoft.AspNetCore.Mvc.ApiExplorer.Testproject: 296 passed, 0 failed.