Repository navigation
Fix virtualized QuickGrid ARIA row count - #70022
Draft
dariatiurina wants to merge 1 commit into
Draft
dariatiurina wants to merge 1 commit into
dariatiurina wants to merge 1 commit into
Conversation
Render QuickGrid when its virtualized provider changes the conceptual row count, keeping the table attribute in sync with loaded rows. Add one Selenium regression using the existing virtualized test component without its provider-side render notification. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix virtualized QuickGrid ARIA row count
Keep virtualized QuickGrid's ARIA row count in sync with provider results.
Description
A virtualized QuickGrid updates its stored total when its provider completes, but Virtualize only rerenders its own rows. The ancestor table's
aria-rowcountcan therefore remain at 1 even after data rows load.Request a QuickGrid render only when the conceptual body row count changes. Existing header, pagination and cancellation conventions remain unchanged. Add one Selenium regression using the existing virtualized test component with its provider-side
StateHasChangeddisabled, so an incidental ancestor render cannot mask the defect.Validation performed locally with the checkout SDK activated:
dotnet build src\Components\test\E2ETest\Microsoft.AspNetCore.Components.E2ETests.csproj --no-restore -v:q -p:UseIisNativeAssets=false- passed without and with the fix, zero warnings/errors.dotnet test src\Components\test\E2ETest\Microsoft.AspNetCore.Components.E2ETests.csproj --no-build --filter 'FullyQualifiedName~QuickGridTest.VirtualizedRowCountIncludesHeaderAfterLoading' --logger 'console;verbosity=normal'- failed as expected without the fix: expected row count 101, actual 1, after the first data row appeared.dotnet test src\Components\test\E2ETest\Microsoft.AspNetCore.Components.E2ETests.csproj --no-build --filter 'FullyQualifiedName~QuickGridTest' --logger 'console;verbosity=normal'- passed with the fix, 13/13 including the identical new regression.The retained regression covers initial provider-driven virtualization on the BasicTestApp WebAssembly path; it does not assert screen-reader speech.
Fixes https://github.com/dotnet/aspnetcore-scenario-tests/issues/159