Skip to content

Give Navigate To the counts it sorts equal F# matches by - #20532

Draft
xperiandri wants to merge 9 commits into
dotnet:mainfrom
xperiandri:feature/navigate-to-sort-counts
Draft

xperiandri wants to merge 9 commits into
dotnet:mainfrom
xperiandri:feature/navigate-to-sort-counts

Conversation

@xperiandri

@xperiandri xperiandri commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Navigate To (Ctrl+T) listed F# matches of the same kind in no particular order, while C# and VB put matches from the current file and nearby folders first. dotnet/roslyn#85280 computes that ordering for F# too if F# supplies parameter and type parameter counts; this passes them.

Draft: cannot build until dotnet/roslyn#85280 has flowed. Stacked on #20531 (first two commits).

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

✅ Release notes checked


✅ Found changes and release notes in following paths:

Warning

No PR link found in some release notes, please consider adding it.

Change path Release notes path Description
`src/Compiler` docs/release-notes/.FSharp.Compiler.Service/11.0.200.md No current pull request URL (#20532) found, please consider adding it
`vsintegration/src` docs/release-notes/.VisualStudio/18.vNext.md

@T-Gro T-Gro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖🕵️ Please shorten the description using this guidance. Focus on the problem and why the change is needed, in simplified technical English. Leave the implementation inventory to the Files tab and retain necessary caveats.

@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Sep 15, 2026
@xperiandri
xperiandri force-pushed the feature/navigate-to-sort-counts branch 2 times, most recently from 3a8db63 to 27af195 Compare September 26, 2026 01:01
@xperiandri
xperiandri force-pushed the feature/navigate-to-sort-counts branch 2 times, most recently from 4c712fc to 537d78b Compare October 8, 2026 01:11
@xperiandri
xperiandri force-pushed the feature/navigate-to-sort-counts branch from 537d78b to 21ed9d9 Compare October 10, 2026 22:28
@xperiandri
xperiandri force-pushed the feature/navigate-to-sort-counts branch from 21ed9d9 to 91ab287 Compare October 29, 2026 22:03
@github-actions

This comment has been minimized.

xperiandri and others added 8 commits November 5, 2026 21:03
Navigate To orders matches that are otherwise equal by these counts for C#
and VB. NavigableItem now carries them: every curried and tupled argument of
the method a declaration compiles to, without the instance and without a
solitary unit argument, and its explicitly declared type parameters.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Navigate To orders matches of the same kind by the folder distance to the
file being edited, then by parameter and type parameter count and name, for
C# and VB. Roslyn computes the same key for F# results once they carry the
counts, which NavigableItem now records.

Needs the FSharpNavigateToSearchResult constructor that takes the counts,
from dotnet/roslyn#85280.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Linking the note added a copy of it instead of editing the first, and `main` has since
opened 11.0.200 for SDK 11.0.200, leaving 11.0.100 shipped.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dotnet/roslyn#85280 takes the counts in the same constructor as whether the
match kept the name's case and where in the name it landed, so the results
window can highlight F# names and rank a case-exact match first. The pattern
matcher reports the spans in the candidate it was given, container first, so
they move to the name's own offsets; the substring fallback for operators and
backticked names reports the span it found itself.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replaying the branch onto main left some files short of the branch's own content; this restores it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…llection assert

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@xperiandri
xperiandri force-pushed the feature/navigate-to-sort-counts branch from b37b08d to a88ad19 Compare November 5, 2026 20:05
…lease note lines

The branch lacked the last fix of dotnet#20531: a named unit argument of a signature (`val f: u: unit -> int`)
is not a parameter. Its copy of the counts commits is also the older one.

The Visual Studio release note carried an empty line and an older copy of the Find All References
bullet, left by earlier union merges. The tree is now the counts PR plus the sort change.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

This comment has been minimized.

@xperiandri
xperiandri force-pushed the feature/navigate-to-sort-counts branch from 2b0618d to 9666930 Compare November 18, 2026 22:00
@github-actions

Copy link
Copy Markdown
Contributor

Build Failure Analysis

Summary - Every recovered Windows build leg that compiled FSharp.Editor failed because the PR calls a Roslyn API overload that is not present in the flowed Roslyn packages.

Root cause: required Roslyn overload has not flowed

The failing _0_ build in each affected job reports the same compiler diagnostic. The PR constructs FSharpNavigateToSearchResult with nine arguments, but Microsoft.VisualStudio.LanguageServices.ExternalAccess 5.14.0-1.26557.1 exposes only the five-argument constructor. The dependency is sourced from Roslyn commit 04b3076a13a7fb376613cb17003059000db1beaa; the required overload is still proposed by open dotnet/roslyn#85280. This matches the PR's draft note that it cannot build until that Roslyn change flows.

Affected errors

Fix attempt - blocked

Delivery - none

No source patch was published. Reverting to the five-argument constructor would remove the case-sensitivity, matched-span, parameter-count, and type-parameter-count data this PR exists to supply. Manually editing the Maestro-generated dependency files would also be invalid; the dependency must flow after the Roslyn API change merges and produces packages.

Checks - binlog_errors and binlog_overview completed successfully for all 30 supplied binlogs. The failing build logs recorded Build: FAILED with FSharp.Editor.fsproj / CoreCompile / Fsc and the single FS0501 root cause; the companion _1_ logs recorded Build: SUCCEEDED, zero errors, and no failed-project evidence. No after-fix command was run because there is no valid repository-local fix and this Windows/Visual Studio dependency prerequisite remains unavailable. The original Azure MSBuild process failed; its numeric process exit code is not present in the supplied binlog evidence.

Build evidence
Evidence Value
Failed project vsintegration/src/FSharp.Editor/FSharp.Editor.fsproj
Failed target/task CoreCompile / Fsc
Resolved external-access package 5.14.0-1.26557.1
Flowed Roslyn commit 04b3076a13a7fb376613cb17003059000db1beaa
Required upstream change dotnet/roslyn#85280 (open)
Azure build https://dev.azure.com/dnceng-public/public/_build/results?buildId=1688852
Workflow run https://github.com/dotnet/fsharp/actions/runs/44418894794

Structured data:

{
  "artifact_kind": "analysis",
  "fix_delivery": "none",
  "fix_status": "blocked",
  "workflow_artifact": "build-failure-analysis"
}

Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow. · copilot · gpt56 · 191.4 AIC · ⌖ 14.9 AIC · ⊞ 23K | [History]( · ◷)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants