Skip to content

test(Tab): update unit test dismiss compile warning - #8539

Merged
ArgoZhang merged 1 commit into
mainfrom
feat-test
Oct 17, 2026
Merged

ArgoZhang merged 1 commit into
mainfrom
feat-test

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Link issues

fixes #8538

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update the Tab unit test to compile cleanly without changing its behavior.

Enhancements:

  • Update the Tab component unit test to avoid a compile warning while preserving its coverage of closing all tabs.

Tests:

  • Adjust the Tab test’s child-element access to use the supported indexed API.

@sourcery-ai

sourcery-ai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Tab CloseAll unit test to use direct child indexing instead of First(), removing the compile warning while preserving the tested dismissal behavior and assertions.

File-Level Changes

Change Details Files
Adjusted the tab dismissal unit test to access the first child element without triggering a compile warning.
  • Replaced LINQ-style First() child access with indexed access using Children[0].
test/UnitTest/Components/TabTest.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#8538 Update the Tab component unit test to dismiss the compile warning while retaining its test coverage. ✅

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@ArgoZhang ArgoZhang added the test This is unit test label Oct 17, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@ArgoZhang ArgoZhang self-assigned this Oct 17, 2026
@ArgoZhang ArgoZhang added this to the v11.0.0 milestone Oct 17, 2026
@ArgoZhang
ArgoZhang merged commit b7fb374 into main Oct 17, 2026
5 checks passed
@ArgoZhang
ArgoZhang deleted the feat-test branch October 17, 2026 00:09
@codecov

codecov Bot commented Oct 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5d1b34b) to head (3d5805e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8539   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          777       777           
  Lines        35339     35339           
=========================================
  Hits         35339     35339           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test This is unit test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(Tab): update unit test dismiss compile warning

1 participant