Skip to content

feat(WinBox): make asset URL resolution compatible with .NET 9+ - #8546

Merged
ArgoZhang merged 1 commit into
mainfrom
feat-winbox
Oct 18, 2026
Merged

ArgoZhang merged 1 commit into
mainfrom
feat-winbox

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Link issues

fixes #8545

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Ensure WinBox asset URL resolution remains compatible with .NET 9 and later.

Bug Fixes:

  • Update the BootstrapBlazor Server project configuration to ensure WinBox asset URLs resolve correctly on .NET 9 and later.

Build:

  • Adjust the BootstrapBlazor Server project file for .NET 9+ asset URL compatibility.

@sourcery-ai

sourcery-ai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR makes a targeted server project configuration change to restore compatible asset URL resolution for .NET 9+ and address issue #8545.

File-Level Changes

Change Details Files
Updates the server project configuration to resolve static asset URLs in a way that remains compatible with .NET 9 and later.
  • Adjusts the project file dependency or configuration responsible for asset URL resolution.
  • Keeps the change isolated to the server project without documented application-code or packaging changes.
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added the enhancement New feature or request label Oct 18, 2026
@bb-auto bb-auto Bot added this to the v11.0.0 milestone Oct 18, 2026

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@ArgoZhang
ArgoZhang merged commit c28f5b0 into main Oct 18, 2026
5 checks passed

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@ArgoZhang
ArgoZhang deleted the feat-winbox branch October 18, 2026 00:54
@codecov

codecov Bot commented Oct 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (bd09928) to head (4a6a3da).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8546   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          775       775           
  Lines        35151     35151           
=========================================
  Hits         35151     35151           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(WinBox): make asset URL resolution compatible with .NET 9+

1 participant