Skip to content

Itin - #56

Closed
SzymonDrosdzol wants to merge 10 commits into
mainfrom
ITIN
Closed

Itin#56
SzymonDrosdzol wants to merge 10 commits into
mainfrom
ITIN

Conversation

@SzymonDrosdzol

Copy link
Copy Markdown

No description provided.

@SzymonDrosdzol
SzymonDrosdzol requested a review from v1ktor0t July 1, 2026 19:42

@v1ktor0t v1ktor0t left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other thing i was thinking was moving the requirement for the value to start with 9 in the regex. but i think having everything encapsulated in a single function ultimately ends up working better.


likelihood := sensitiveinformation.LikelihoodUnlikely
if contextMatch {
likelihood = sensitiveinformation.LikelihoodLikely

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why it's not VeryLikely in this case?

@SzymonDrosdzol SzymonDrosdzol Jul 2, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how they wanted it for SSN, so I'm assuming it'll be the same here.
See: https://github.com/google/osv-scalibr/pull/2208/changes#diff-de016d11e0488589101a53de1c99491fe882d6bd27d4b4bb5f3666cb9966c728R76

I think the idea is VeryLikely is reserved for checksum validated stuff like CCs and IBANs

@SzymonDrosdzol

Copy link
Copy Markdown
Author

the other thing i was thinking was moving the requirement for the value to start with 9 in the regex. but i think having everything encapsulated in a single function ultimately ends up working better.

I think this way is far more readable and less error prone. Though I see why some might prefer it in the regex.

@v1ktor0t

v1ktor0t commented Jul 3, 2026

Copy link
Copy Markdown
Member

lgtm 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants