Itin - #56
Conversation
v1ktor0t
left a comment
There was a problem hiding this comment.
the other thing i was thinking was moving the requirement for the value to start with 9 in the regex. but i think having everything encapsulated in a single function ultimately ends up working better.
|
|
||
| likelihood := sensitiveinformation.LikelihoodUnlikely | ||
| if contextMatch { | ||
| likelihood = sensitiveinformation.LikelihoodLikely |
There was a problem hiding this comment.
any reason why it's not VeryLikely in this case?
There was a problem hiding this comment.
That's how they wanted it for SSN, so I'm assuming it'll be the same here.
See: https://github.com/google/osv-scalibr/pull/2208/changes#diff-de016d11e0488589101a53de1c99491fe882d6bd27d4b4bb5f3666cb9966c728R76
I think the idea is VeryLikely is reserved for checksum validated stuff like CCs and IBANs
I think this way is far more readable and less error prone. Though I see why some might prefer it in the regex. |
|
lgtm 🚀 |
No description provided.