fix(base): support readlink applet from busybox - #2682
Open
bdrung wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
base
Collaborator
|
Do we now need to also install |
Member
Author
|
Oh, that is a valid point. Let me reconsider the solution. |
devkontrol
marked this pull request as draft
August 27, 2026 17:36
bdrung
marked this pull request as ready for review
September 1, 2026 17:47
Member
Author
|
Reworked the code to use realpath and fall back to readlink. |
devkontrol
reviewed
Sep 1, 2026
busybox's `readlink` applet does not support the option `-e` option. These `readlink` calls can be replaced by `realpath`, but `realpath` is not included in the initrd. So support using `readlink` (when busybox is used) and fall back to keep using `readlink` otherwise. Since `realpath` will return successfully on non-existing path, check the path exists if needed. Part of: dracut-ng#2437
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
busybox's
readlinkapplet does not support the option-eoption.These
readlinkcalls can be replaced byrealpath, butrealpathis not included in the initrd. So support usingreadlink(when busybox is used) and fall back to keep usingreadlinkotherwise. Sincerealpathwill return successfully on non-existing path, check the path exists if needed.Part of: #2437
Checklist