Skip to content

Commit c575f38

Browse files
committed
test(e2e): add sha256 verification by task ID in containerd/proxy tests
- Add SHA256 verification via task ID alongside existing output-path checks - Sleep 1s before seed client pod init to allow task propagation - Verify task ID hash matches expected value in containerd and proxy tests - Use `CalculateSha256ByTaskID` with hardcoded task ID in containerd test - Add `WithTaskIDTag("proxy-bytes-100")` tag when computing task ID in proxy test Signed-off-by: Gaius <gaius.qi@gmail.com>
1 parent f963142 commit c575f38

2 files changed

Lines changed: 18 additions & 1 deletion

File tree

test/e2e/containerd_test.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package e2e
1818

1919
import (
2020
"fmt"
21+
"time"
2122

2223
. "github.com/onsi/ginkgo/v2" //nolint
2324
. "github.com/onsi/gomega" //nolint
@@ -71,6 +72,18 @@ var _ = Describe("Containerd with CRI support", func() {
7172
Expect(err).NotTo(HaveOccurred())
7273
Expect(taskMetadata.Sha256).To(Equal(sha256sum))
7374
}
75+
76+
time.Sleep(1 * time.Second)
77+
seedClientPods := make([]*util.PodExec, 3)
78+
for i := range 3 {
79+
seedClientPods[i], err = util.SeedClientExec(i)
80+
fmt.Println(err)
81+
Expect(err).NotTo(HaveOccurred())
82+
}
83+
84+
sha256sum, err := util.CalculateSha256ByTaskID(seedClientPods, "99f960a3d990bc51293c661d50aa89af1467e4dbc17525812e3c85cc98a3ed46")
85+
Expect(err).NotTo(HaveOccurred())
86+
Expect("99f960a3d990bc51293c661d50aa89af1467e4dbc17525812e3c85cc98a3ed46").To(Equal(sha256sum))
7487
})
7588

7689
It("rmi should be ok", Label("containerd", "rmi"), func() {

test/e2e/proxy_test.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,11 @@ var _ = Describe("Download Using Proxy", func() {
287287
Expect(err).NotTo(HaveOccurred())
288288
fmt.Println(string(out))
289289

290-
sha256sum, err := util.CalculateSha256ByOutput([]*util.PodExec{clientPod}, testFile.GetOutputPath())
290+
sha256sum, err := util.CalculateSha256ByTaskID([]*util.PodExec{clientPod}, testFile.GetTaskID(util.WithTaskIDTag("proxy-bytes-100")))
291+
Expect(err).NotTo(HaveOccurred())
292+
Expect(testFile.GetSha256()).To(Equal(sha256sum))
293+
294+
sha256sum, err = util.CalculateSha256ByOutput([]*util.PodExec{clientPod}, testFile.GetOutputPath())
291295
Expect(err).NotTo(HaveOccurred())
292296
got, err := testFile.GetRangeSha256("-100", testFile.GetInfo().Size())
293297
Expect(err).NotTo(HaveOccurred())

0 commit comments

Comments
 (0)