Skip to content

Commit f963142

Browse files
authored
test(e2e): remove seed client sha256 verification from containerd and concurrency tests
The new client (v1.4.2) no longer propagates task content to seed client pods the same way. Remove seed client CalculateSha256ByTaskID checks from: - containerd_test.go: drop seed client pod SHA256 loop and associated time.Sleep after containerd pull - concurrency_test.go: drop seed client pod SHA256 checks from concurrent 200, 500, and 1000 tests
1 parent c03fff7 commit f963142

2 files changed

Lines changed: 0 additions & 48 deletions

File tree

test/e2e/concurrency_test.go

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -69,17 +69,6 @@ var _ = Describe("Download Concurrency", func() {
6969
sha256sum, err := util.CalculateSha256ByTaskID([]*util.PodExec{clientPod}, testFile.GetTaskID())
7070
Expect(err).NotTo(HaveOccurred())
7171
Expect(testFile.GetSha256()).To(Equal(sha256sum))
72-
73-
seedClientPods := make([]*util.PodExec, 3)
74-
for i := range 3 {
75-
seedClientPods[i], err = util.SeedClientExec(i)
76-
fmt.Println(err)
77-
Expect(err).NotTo(HaveOccurred())
78-
}
79-
80-
sha256sum, err = util.CalculateSha256ByTaskID(seedClientPods, testFile.GetTaskID())
81-
Expect(err).NotTo(HaveOccurred())
82-
Expect(testFile.GetSha256()).To(Equal(sha256sum))
8372
})
8473

8574
It("concurrent 500 should be ok", Label("concurrent", "500"), func() {
@@ -94,17 +83,6 @@ var _ = Describe("Download Concurrency", func() {
9483
sha256sum, err := util.CalculateSha256ByTaskID([]*util.PodExec{clientPod}, testFile.GetTaskID())
9584
Expect(err).NotTo(HaveOccurred())
9685
Expect(testFile.GetSha256()).To(Equal(sha256sum))
97-
98-
seedClientPods := make([]*util.PodExec, 3)
99-
for i := range 3 {
100-
seedClientPods[i], err = util.SeedClientExec(i)
101-
fmt.Println(err)
102-
Expect(err).NotTo(HaveOccurred())
103-
}
104-
105-
sha256sum, err = util.CalculateSha256ByTaskID(seedClientPods, testFile.GetTaskID())
106-
Expect(err).NotTo(HaveOccurred())
107-
Expect(testFile.GetSha256()).To(Equal(sha256sum))
10886
})
10987

11088
It("concurrent 1000 should be ok", Label("concurrent", "1000"), func() {
@@ -119,17 +97,6 @@ var _ = Describe("Download Concurrency", func() {
11997
sha256sum, err := util.CalculateSha256ByTaskID([]*util.PodExec{clientPod}, testFile.GetTaskID())
12098
Expect(err).NotTo(HaveOccurred())
12199
Expect(testFile.GetSha256()).To(Equal(sha256sum))
122-
123-
seedClientPods := make([]*util.PodExec, 3)
124-
for i := range 3 {
125-
seedClientPods[i], err = util.SeedClientExec(i)
126-
fmt.Println(err)
127-
Expect(err).NotTo(HaveOccurred())
128-
}
129-
130-
sha256sum, err = util.CalculateSha256ByTaskID(seedClientPods, testFile.GetTaskID())
131-
Expect(err).NotTo(HaveOccurred())
132-
Expect(testFile.GetSha256()).To(Equal(sha256sum))
133100
})
134101
})
135102
})

test/e2e/containerd_test.go

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ package e2e
1818

1919
import (
2020
"fmt"
21-
"time"
2221

2322
. "github.com/onsi/ginkgo/v2" //nolint
2423
. "github.com/onsi/gomega" //nolint
@@ -72,20 +71,6 @@ var _ = Describe("Containerd with CRI support", func() {
7271
Expect(err).NotTo(HaveOccurred())
7372
Expect(taskMetadata.Sha256).To(Equal(sha256sum))
7473
}
75-
76-
time.Sleep(1 * time.Second)
77-
seedClientPods := make([]*util.PodExec, 3)
78-
for i := range 3 {
79-
seedClientPods[i], err = util.SeedClientExec(i)
80-
fmt.Println(err)
81-
Expect(err).NotTo(HaveOccurred())
82-
}
83-
84-
for _, taskMetadata := range taskMetadatas {
85-
sha256sum, err := util.CalculateSha256ByTaskID(seedClientPods, taskMetadata.ID)
86-
Expect(err).NotTo(HaveOccurred())
87-
Expect(taskMetadata.Sha256).To(Equal(sha256sum))
88-
}
8974
})
9075

9176
It("rmi should be ok", Label("containerd", "rmi"), func() {

0 commit comments

Comments
 (0)