feat(scheduler): handle HitLocalCache in peer register & upgrade v2.2.32 - #4881
Merged
Conversation
- Add early-return path for `HitLocalCache` flag in peer register - Transition task/peer FSM states and send `HitLocalCacheResponse` directly without scheduling or triggering seed peer - Bump `d7y.io/api/v2` dependency from v2.2.30 to v2.2.32 Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi
requested review from
CooooolFrog,
EvanCley,
bergwolf,
chlins and
xujihui1985
July 20, 2026 15:44
Simplifies the comment for the local cache hit case by removing details about HitLocalCacheResponse and peer reporting behavior. Signed-off-by: Gaius <gaius.qi@gmail.com>
- Replace `HitLocalCache`/`HitLocalCacheResponse` with `MetadataOnly`/`MetadataOnlyResponse` in peer registration handling - Update log message to reflect new response type - Bump `google.golang.org/grpc` from v1.82.0 to v1.82.1 Signed-off-by: Gaius <gaius.qi@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4881 +/- ##
==========================================
- Coverage 28.12% 28.09% -0.04%
==========================================
Files 232 232
Lines 23158 23186 +28
==========================================
Hits 6513 6513
- Misses 16197 16224 +27
- Partials 448 449 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
hhhhsdxxxx
previously approved these changes
Jul 21, 2026
- Bump Node.js base image from 20 to 24 (Alpine) in Dockerfile and build script - Add `yarn.lock` copy step to improve layer caching and ensure reproducible installs - Update manager/console submodule to latest commit Signed-off-by: Gaius <gaius.qi@gmail.com>
gaius-qi
dismissed stale reviews from BraveY, hhhhsdxxxx, and chlins
via
July 21, 2026 03:08
f7e3f80
gaius-qi
enabled auto-merge (squash)
July 21, 2026 03:09
hhhhsdxxxx
approved these changes
Jul 21, 2026
CormickKneey
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HitLocalCacheflag in peer registerHitLocalCacheResponsedirectly without scheduling or triggering seed peerd7y.io/api/v2dependency from v2.2.30 to v2.2.32Related Issue
#4880
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist