Feature: Add Web Push API Support via PushForge Integration - #944
Feature: Add Web Push API Support via PushForge Integration#944atharva-matale wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 Walkthrough演进概述该更改移除了 变更
预估代码审查工作量🎯 1 (微不足道) | ⏱️ ~2 分钟 庆祝诗
🚥 Pre-merge checks | ✅ 1 | ❌ 4❌ Failed checks (4 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
|
感谢贡献。 这边看了下,目前还没有看到 Web Push 功能的实际实现内容。 如果你这边已经有明确的实现计划,可以在这个 PR 里同步一下准备怎么做、预计覆盖哪些能力;如果暂时没有的话,后续这边开发者会自己着手实现。 |
|
@dreamhunter2333 结论:当前仓库代码里没有看到任何 Web Push / PushForge 的实际实现。搜索了 建议方向(如果要推进该 PR):
目前 PR 只有格式化变更,建议先补充实现计划或提交最小可用的 Web Push 功能,再继续审查。 |
|
Thanks for the contribution, and sorry for the delayed review. I checked the PR, and at the moment I still don’t see the actual Web Push / PushForge implementation in the code. The current diff only contains formatting changes in , so it doesn’t match the feature described in the PR. If you already have a concrete implementation plan, please share what parts you intend to add in this PR and which capabilities it will cover. If not, we may implement this feature ourselves later on our side. Thanks again for the contribution. |
|
Thanks for the contribution, and sorry for the delayed review. I checked the PR, and at the moment I still don’t see the actual Web Push / PushForge implementation in the code. The current diff only contains formatting changes in worker/src/telegram_api/telegram.ts, so it doesn’t match the feature described in the PR. If you already have a concrete implementation plan, please share what parts you intend to add in this PR and which capabilities it will cover. If not, we may implement this feature ourselves later on our side. Thanks again for the contribution. |
Closes #943
This PR integrates the PushForge library to enable Web Push notifications for temporary email addresses. This allows users to receive real-time updates on their email's status without needing to constantly refresh the page, improving the user experience. The implementation handles subscription management and message sending through PushForge, leveraging its existing infrastructure for reliable delivery.
Summary by CodeRabbit
发版说明