Skip to content

Updated 'git-artifact' to 1.9.0. - #3224

Merged
AlexSkrypnyk merged 1 commit into
mainfrom
feature/update-git-artifact
Oct 21, 2026
Merged

AlexSkrypnyk merged 1 commit into
mainfrom
feature/update-git-artifact

Conversation

@AlexSkrypnyk

Copy link
Copy Markdown
Member

Summary

vortex-deploy-artifact now downloads git-artifact 1.9.0 by default and checks it against the 1.9.0 binary's SHA256, b8282b9a07f6d9a11d4b0dcfa248848ae57182ec8626eee8bee4ee12cdd36a39.

The script pinned VORTEX_DEPLOY_ARTIFACT_GIT_ARTIFACT_VERSION to 1.8.0, so every artifact deployment that leaves that variable unset kept pulling the older binary after 1.9.0 shipped. 1.9.0 is a dependency-only release: the 1.8.0...1.9.0 compare touches git-artifact's CI workflows, Dockerfile, Composer manifests and tests, and leaves src/ untouched, so the options the script passes (--root, --source, --branch, --gitignore, --log, --cleanup-stale, --cleanup-pattern, --cleanup-age) work exactly as before.

After merge, the "Installing artifact builder." step fetches releases/download/1.9.0/git-artifact, and consumer sites pick it up with their next drevops/vortex-tooling update. A project that sets both VORTEX_DEPLOY_ARTIFACT_GIT_ARTIFACT_VERSION and VORTEX_DEPLOY_ARTIFACT_GIT_ARTIFACT_SHA256 in .env keeps the binary it pinned. Installer fixtures don't change, because the script ships in the tooling package and not in the template files.

Before / After

BEFORE                                    AFTER

vortex-deploy-artifact                    vortex-deploy-artifact
┌───────────────────────────────────┐     ┌───────────────────────────────────┐
│ VERSION  1.8.0                    │     │ VERSION  1.9.0                    │
│ SHA256   31133d0d ... 1977d9d     │     │ SHA256   b8282b9a ... cdd36a39    │
└─────────────────┬─────────────────┘     └─────────────────┬─────────────────┘
                  │ curl                                    │ curl
                  ▼                                         ▼
  releases/download/1.8.0/git-artifact      releases/download/1.9.0/git-artifact
                  │ sha256sum -c                            │ sha256sum -c
                  ▼                                         ▼
     git-artifact --root --source ...          git-artifact --root --source ...
                                               (same options, same flow)

Changes

Deployment script

  • .vortex/tooling/src/vortex-deploy-artifact: the default VORTEX_DEPLOY_ARTIFACT_GIT_ARTIFACT_VERSION is 1.9.0 and the default VORTEX_DEPLOY_ARTIFACT_GIT_ARTIFACT_SHA256 is b8282b9a07f6d9a11d4b0dcfa248848ae57182ec8626eee8bee4ee12cdd36a39. That digest is the one GitHub reports for the release's git-artifact asset, and it matches a local shasum -a 256 of the downloaded binary.

Tests

  • .vortex/tooling/tests/unit/deploy-artifact.bats: the 3 expected download URLs point at 1.9.0. These tests mock sha256sum, so the real digest gets exercised by DeploymentTest::testDeploymentArtifact, which downloads the binary, runs the checksum and pushes to a local remote.

Documentation

  • .vortex/docs/content/deployment/artifact.mdx: the documented default version is 1.9.0.
  • .vortex/docs/content/development/variables.mdx: regenerated with ahoy update-docs, so the version and checksum rows match the script.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 4 billable files and costs up to $1.00.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 28 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 3 included reviews currently available. Your 79 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: dfe53131-046f-4c69-aa4a-58c6e21f2906
📥 Commits

Reviewing files that changed from the base of the PR and between 6eefbea and e35cee4.

📒 Files selected for processing: 4
  • .vortex/docs/content/deployment/artifact.mdx
  • .vortex/docs/content/development/variables.mdx
  • .vortex/tooling/src/vortex-deploy-artifact
  • .vortex/tooling/tests/unit/deploy-artifact.bats
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

@github-actions

This comment has been minimized.

@AlexSkrypnyk

This comment has been minimized.

@github-actions

Copy link
Copy Markdown

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (233/233)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@AlexSkrypnyk

Copy link
Copy Markdown
Member Author

Code coverage (threshold: 90%)

  Classes: 100.00% (1/1)
  Methods: 100.00% (2/2)
  Lines:   100.00% (233/233)
Per-class coverage
Drupal\ys_demo\Plugin\Block\CounterBlock
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 10/ 10)

@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.09%. Comparing base (6eefbea) to head (e35cee4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3224      +/-   ##
==========================================
- Coverage   92.29%   92.09%   -0.20%     
==========================================
  Files         113      105       -8     
  Lines        5099     4933     -166     
  Branches       49        3      -46     
==========================================
- Hits         4706     4543     -163     
+ Misses        393      390       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown

📖 Documentation preview for this pull request has been deployed to Netlify:

https://6ad8740b5ede49b6ab3bfd37--vortex-docs.netlify.app

This preview is rebuilt on every commit and is not the production documentation site.

@AlexSkrypnyk AlexSkrypnyk added the Needs review Pull request needs a review from assigned developers label Oct 21, 2026
@AlexSkrypnyk
AlexSkrypnyk merged commit 1b86151 into main Oct 21, 2026
36 checks passed
@AlexSkrypnyk
AlexSkrypnyk deleted the feature/update-git-artifact branch October 21, 2026 09:18
@github-project-automation github-project-automation Bot moved this from BACKLOG to Release queue in Vortex 1.x Oct 21, 2026
@AlexSkrypnyk AlexSkrypnyk added this to the 1.42.0 milestone Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs review Pull request needs a review from assigned developers

Projects

Status: Released in 1.42.0

Development

Successfully merging this pull request may close these issues.

1 participant