Repository navigation
Updated 'git-artifact' to 1.9.0. - #3224
Conversation
|
Warning Review limit reached
This review includes 4 billable files and costs up to $1.00.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 28 minutes for your next included review. View limit details
Comment |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
|
Code coverage (threshold: 90%) Per-class coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3224 +/- ##
==========================================
- Coverage 92.29% 92.09% -0.20%
==========================================
Files 113 105 -8
Lines 5099 4933 -166
Branches 49 3 -46
==========================================
- Hits 4706 4543 -163
+ Misses 393 390 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6ad8740b5ede49b6ab3bfd37--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
Summary
vortex-deploy-artifactnow downloadsgit-artifact1.9.0 by default and checks it against the 1.9.0 binary's SHA256,b8282b9a07f6d9a11d4b0dcfa248848ae57182ec8626eee8bee4ee12cdd36a39.The script pinned
VORTEX_DEPLOY_ARTIFACT_GIT_ARTIFACT_VERSIONto1.8.0, so every artifact deployment that leaves that variable unset kept pulling the older binary after 1.9.0 shipped. 1.9.0 is a dependency-only release: the1.8.0...1.9.0compare touches git-artifact's CI workflows,Dockerfile, Composer manifests and tests, and leavessrc/untouched, so the options the script passes (--root,--source,--branch,--gitignore,--log,--cleanup-stale,--cleanup-pattern,--cleanup-age) work exactly as before.After merge, the "Installing artifact builder." step fetches
releases/download/1.9.0/git-artifact, and consumer sites pick it up with their nextdrevops/vortex-toolingupdate. A project that sets bothVORTEX_DEPLOY_ARTIFACT_GIT_ARTIFACT_VERSIONandVORTEX_DEPLOY_ARTIFACT_GIT_ARTIFACT_SHA256in.envkeeps the binary it pinned. Installer fixtures don't change, because the script ships in the tooling package and not in the template files.Before / After
Changes
Deployment script
.vortex/tooling/src/vortex-deploy-artifact: the defaultVORTEX_DEPLOY_ARTIFACT_GIT_ARTIFACT_VERSIONis1.9.0and the defaultVORTEX_DEPLOY_ARTIFACT_GIT_ARTIFACT_SHA256isb8282b9a07f6d9a11d4b0dcfa248848ae57182ec8626eee8bee4ee12cdd36a39. That digest is the one GitHub reports for the release'sgit-artifactasset, and it matches a localshasum -a 256of the downloaded binary.Tests
.vortex/tooling/tests/unit/deploy-artifact.bats: the 3 expected download URLs point at1.9.0. These tests mocksha256sum, so the real digest gets exercised byDeploymentTest::testDeploymentArtifact, which downloads the binary, runs the checksum and pushes to a local remote.Documentation
.vortex/docs/content/deployment/artifact.mdx: the documented default version is1.9.0..vortex/docs/content/development/variables.mdx: regenerated withahoy update-docs, so the version and checksum rows match the script.