Fix postgres and CockroachDB diff cases that write failing SQL around moves, renames, roles and generated columns

Postgres:
- Count the brackets of a custom type's SQL type as array dimensions.
- Drop and create the foreign keys of a recreated generated column one
  time each, and create its indexes and unique constraints one time.
- Rename a view in its old schema before it moves, and move it with its
  old kind.
- Drop a recreated view after its rename or move.
- Run the policy drops, foreign key drops and row level security
  statements of a moved table after `SET SCHEMA`.
- Run `DROP ROLE` after the policy statements.
- Run `DROP EXPRESSION` first and write no `USING` clause for a
  generated column.
- Find the enum columns that a format 7 snapshot stores without a type
  schema when the enum is recreated, with the s06 tests and fixtures.

CockroachDB:
- Drop a view that reads a renamed or moved table before the table
  statement and create it after it. Replace `recreate_view` with a
  `drop_view` that has a `cause`, in the diff, in push and in
  `cockroachExplain`.
- Write both statements for a view or a sequence that moves and gets a
  new name, and look up the old view of a moved view that is recreated.
- Name the table in an index rename or drop when two tables hold the
  index name.
- Write `RENAME CONSTRAINT` for a check rename.
- Select the row of the renamed check, index, primary key, foreign key
  or policy by its table.
- Change the column type when only the type schema or the array
  dimensions change, and count the brackets of a custom type's SQL type.
- Run table renames and moves before the statements that name the table
  in its new place.
- Create the foreign keys of a recreated generated column again.
- Run `DROP ROLE` after the policy statements.

Author: dankochetov

drizzle-kit/src/cli/commands/push-cockroach.ts

@@ -186,7 +186,7 @@ export const suggestions = async (db: DB, jsonStatements: JsonStatement[], hints
 
 	const filtered = jsonStatements.filter((it) => {
 		// discussion -
-		if (it.type === 'recreate_view') return false;
+		if (it.type === 'drop_view' && it.cause) return false;
 
 		/*
 			drizzle-kit push does not handle alternations of views definitions

drizzle-kit/src/cli/views.ts

@@ -507,8 +507,8 @@ export const cockroachExplain = (st: StatementCockroach) => {
 		if (d.columns) cause += `│ columns: [${d.columns.from.join(',')}] -> [${d.columns.to.join(',')}]\n`;
 	}
 
-	if (st.type === 'recreate_view') {
-		const { from, to } = st;
+	if (st.type === 'drop_view' && st.cause) {
+		const { view: from, cause: to } = st;
 
 		const key = `${to.schema}.${to.name}`;
 		title += `${key} view changed:`;

drizzle-kit/src/dialects/cockroach/convertor.ts

@@ -62,12 +62,6 @@ const moveViewConvertor = convertor('move_view', (st) => {
 	return `ALTER${view.materialized ? ' MATERIALIZED' : ''} VIEW ${from} SET SCHEMA "${toSchema}";`;
 });
 
-const recreateViewConvertor = convertor('recreate_view', (st) => {
-	const drop = dropViewConvertor.convert({ view: st.from }) as string;
-	const create = createViewConvertor.convert({ view: st.to }) as string;
-	return [drop, create];
-});
-
 const createTableConvertor = convertor('create_table', (st) => {
 	const { schema, name, columns, pk, checks, policies, isRlsEnabled, indexes } = st.table;
 
@@ -245,24 +239,30 @@ const alterColumnConvertor = convertor('alter_column', (st) => {
 
 	const key = column.schema !== 'public' ? `"${column.schema}"."${column.table}"` : `"${column.table}"`;
 
+	// `hasNewType` also counts a change of only `typeSchema`, because an enum with the same name in another
+	// schema is another type. A change of only `dimensions` gets a plain cast. Cockroach has no cast between
+	// most scalar types and their array types, so the user writes that conversion into the USING clause.
+	const hasNewType = !!(diff.type || diff.typeSchema || diff.dimensions);
 	// TODO need to recheck this
-	const recreateDefault = diff.type && (isEnum || wasEnum) && (diff.$left.default);
+	const recreateDefault = hasNewType && (isEnum || wasEnum || diff.dimensions) && (diff.$left.default);
 	if (recreateDefault) {
 		statements.push(`ALTER TABLE ${key} ALTER COLUMN "${column.name}" DROP DEFAULT;`);
 	}
 
-	if (diff.type) {
+	if (hasNewType) {
 		const typeSchema = column.typeSchema && column.typeSchema !== 'public' ? `"${column.typeSchema}".` : '';
 		const textProxy = wasEnum && isEnum ? 'text::' : ''; // using enum1::text::enum2
 		const suffix = isEnum
 			? ` USING "${column.name}"::${textProxy}${typeSchema}"${column.type}"${'[]'.repeat(column.dimensions)}`
+			: diff.dimensions
+			? ` USING "${column.name}"::${column.type}${'[]'.repeat(column.dimensions)}`
 			: '';
 
-		const type = diff.typeSchema?.to && diff.typeSchema.to !== 'public'
-			? `"${diff.typeSchema.to}"."${diff.type.to}"`
+		const type = typeSchema
+			? `${typeSchema}"${column.type}"`
 			: isEnum
-			? `"${diff.type.to}"`
-			: diff.type.to;
+			? `"${column.type}"`
+			: column.type;
 
 		statements.push(
 			`ALTER TABLE ${key} ALTER COLUMN "${column.name}" SET DATA TYPE ${type}${
@@ -387,21 +387,25 @@ const dropIndexConvertor = convertor('drop_index', (st) => {
 	const key = index.schema !== 'public'
 		? `"${index.schema}".`
 		: '';
+	const table = st.isNameShared ? `"${index.table}"@` : '';
 
-	return `DROP INDEX ${key}"${st.index.name}"${cascade};`;
+	return `DROP INDEX ${key}${table}"${st.index.name}"${cascade};`;
 });
 
 const recreateIndexConvertor = convertor('recreate_index', (st) => {
 	const { diff } = st;
-	const drop = dropIndexConvertor.convert({ index: diff.$right }) as string;
+	// `isNameShared` is false because the index renames and the index drops run before this statement. At this
+	// point only one table of the schema holds the name of this index.
+	const drop = dropIndexConvertor.convert({ index: diff.$right, isNameShared: false }) as string;
 	const create = createIndexConvertor.convert({ index: diff.$right, newTable: false }) as string;
 	return [drop, create];
 });
 
 const renameIndexConvertor = convertor('rename_index', (st) => {
-	const key = st.schema !== 'public' ? `"${st.schema}"."${st.from}"` : `"${st.from}"`;
+	const key = st.schema !== 'public' ? `"${st.schema}".` : '';
+	const table = st.isNameShared ? `"${st.table}"@` : '';
 
-	return `ALTER INDEX ${key} RENAME TO "${st.to}";`;
+	return `ALTER INDEX ${key}${table}"${st.from}" RENAME TO "${st.to}";`;
 });
 
 const addPrimaryKeyConvertor = convertor('add_pk', (st) => {
@@ -723,7 +727,6 @@ const convertors = [
 	dropViewConvertor,
 	renameViewConvertor,
 	moveViewConvertor,
-	recreateViewConvertor,
 	createTableConvertor,
 	dropTableConvertor,
 	renameTableConvertor,