fix(agent): preserve image-generated slide intent - #128
Merged
Conversation
Deploying sciclaw with
|
| Latest commit: |
bacb580
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89f2e43c.sciclaw.pages.dev |
| Branch Preview URL: | https://codex-image-slide-artifact-r.sciclaw.pages.dev |
Owner
Author
|
Independent review packet and copyable GitHub-review prompt: |
Owner
Author
|
Independent exact-head review complete for .\n\nVerdict: APPROVE — no material findings remain.\n\nThe review identified two earlier gaps (the unshipped presentation-skill dependency and incomplete contract assertions), both remediated. A follow-up assembled-prompt regression test now covers the Codex provider wiring, canonical skill pointer, and absence of the obsolete provenance warning. Final CI is green: fmt, vet, test, and Cloudflare Pages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Routes image generation by the requested final artifact and removes the misleading provenance warning that caused wordless conceptual illustrations. Vendors the repository-local ship workflow and adds a gated SciClaw Brew/Data3 continuation.
Architecture
The hosted-tool note and workspace template now point to one canonical built-in
image-generationskill. It distinguishes standalone images, visual assets, editable presentations, and complete worded image-generated slides. Provider transport and Discord attachment code are unchanged.Verification
go test ./... -count=1go vet ./...go build ./cmd/picoclawgit diff --checkquick_validate.pyCleanup
Collapsed duplicated routing policy into the
image-generationskill; runtime and template are concise pointers. No provider fallback or parallel implementation was added.Review packet
docs/ops/correspondence-image-slide-artifact-routing.mdcontains the complete evidence and independent-review prompt.Limits and rollback
No merge, tag, release, Homebrew update, or deployment has occurred. Revert this PR to restore prior prompt/skill behavior. Live DEB four-mode acceptance is a post-release canary.