Add testable error handling to SDK version function

See #90

Author: dru1x

src/ExpoPushConnector.php

@@ -25,6 +25,9 @@ class ExpoPushConnector extends Connector
 
     public const MAX_CONCURRENT_REQUESTS = 6;
 
+    private static bool $sdkVersionResolved = false;
+    private static ?string $sdkVersion = null;
+
     public function __construct(
         protected ?string $authToken = null,
         ?RateLimitStore   $rateLimitStore = null,
@@ -83,17 +86,30 @@ protected function resolveRateLimitStore(): RateLimitStore
      */
     public function sdkVersion(): string
     {
-        static $version = null;
+        if (!self::$sdkVersionResolved) {
+            self::$sdkVersion         = self::resolveSdkVersion(dirname(__DIR__) . '/composer.json');
+            self::$sdkVersionResolved = true;
+        }
 
-        if (!$version) {
-            $composer = json_decode(
-                file_get_contents(dirname(__DIR__) . '/composer.json'),
-            );
+        return self::$sdkVersion;
+    }
 
-            $version = InstalledVersions::getPrettyVersion($composer->name);
+    /**
+     * Resolve the installed version from composer.json, falling back to 'unknown' if it can't be determined
+     */
+    private static function resolveSdkVersion(string $composerJsonPath): string
+    {
+        if (!is_readable($composerJsonPath)) {
+            return 'unknown';
         }
 
-        return (string) $version;
+        try {
+            $composer = json_decode(file_get_contents($composerJsonPath), flags: JSON_THROW_ON_ERROR);
+
+            return InstalledVersions::getPrettyVersion($composer->name) ?? 'unknown';
+        } catch (Throwable) {
+            return 'unknown';
+        }
     }
 
     // Internals ----

tests/Unit/ExpoPushConnectorTest.php

@@ -4,17 +4,48 @@
 
 namespace Dru1x\ExpoPush\Tests\Unit;
 
+use Composer\InstalledVersions;
 use Dru1x\ExpoPush\Config\RetryConfig;
 use Dru1x\ExpoPush\ExpoPushConnector;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
+use ReflectionMethod;
+use ReflectionProperty;
 use Saloon\Http\Auth\TokenAuthenticator;
 use Saloon\RateLimitPlugin\Exceptions\LimitException;
 use Saloon\RateLimitPlugin\Limit;
 use Saloon\RateLimitPlugin\Stores\MemoryStore;
 
 class ExpoPushConnectorTest extends TestCase
 {
+    private ?bool $originalSdkVersionResolved = null;
+    private ?string $originalSdkVersion       = null;
+
+    /** @var list<string> */
+    private array $tempFiles = [];
+
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        $this->originalSdkVersionResolved = (new ReflectionProperty(ExpoPushConnector::class, 'sdkVersionResolved'))->getValue();
+        $this->originalSdkVersion         = (new ReflectionProperty(ExpoPushConnector::class, 'sdkVersion'))->getValue();
+    }
+
+    protected function tearDown(): void
+    {
+        (new ReflectionProperty(ExpoPushConnector::class, 'sdkVersionResolved'))->setValue(null, $this->originalSdkVersionResolved);
+        (new ReflectionProperty(ExpoPushConnector::class, 'sdkVersion'))->setValue(null, $this->originalSdkVersion);
+
+        foreach ($this->tempFiles as $tempFile) {
+            is_file($tempFile) && unlink($tempFile);
+        }
+
+        $this->tempFiles = [];
+
+        parent::tearDown();
+    }
+
     #[Test]
     public function resolves_the_expo_push_api_base_url(): void
     {
@@ -113,8 +144,83 @@ public function custom_retry_configuration_is_used_when_supplied(): void
         $this->assertFalse($connector->throwOnMaxTries);
     }
 
+    // SDK Version ----
+
+    #[Test]
+    public function sdk_version_resolves_the_real_installed_version(): void
+    {
+        $composerJsonPath = dirname(__DIR__, 2) . '/composer.json';
+        $composer         = json_decode(file_get_contents($composerJsonPath));
+
+        $this->assertSame(
+            InstalledVersions::getPrettyVersion($composer->name),
+            $this->resolveSdkVersion($composerJsonPath),
+        );
+    }
+
+    #[Test]
+    public function sdk_version_falls_back_to_unknown_when_composer_json_is_missing(): void
+    {
+        $this->assertSame('unknown', $this->resolveSdkVersion('/nonexistent/composer.json'));
+    }
+
+    #[Test]
+    public function sdk_version_falls_back_to_unknown_when_composer_json_is_malformed(): void
+    {
+        $path = $this->writeTempFile('{not valid json');
+
+        $this->assertSame('unknown', $this->resolveSdkVersion($path));
+    }
+
+    #[Test]
+    public function sdk_version_falls_back_to_unknown_when_the_package_is_not_installed(): void
+    {
+        $path = $this->writeTempFile(json_encode(['name' => 'not/a-real-package']));
+
+        $this->assertSame('unknown', $this->resolveSdkVersion($path));
+    }
+
+    #[Test]
+    public function sdk_version_does_not_recompute_once_resolved(): void
+    {
+        (new ReflectionProperty(ExpoPushConnector::class, 'sdkVersion'))->setValue(null, 'cached-test-value');
+        (new ReflectionProperty(ExpoPushConnector::class, 'sdkVersionResolved'))->setValue(null, true);
+
+        $connector = new ExpoPushConnector();
+
+        $this->assertSame('cached-test-value', $connector->sdkVersion());
+    }
+
+    #[Test]
+    public function sdk_version_caches_a_falsy_resolved_value_instead_of_recomputing_it(): void
+    {
+        (new ReflectionProperty(ExpoPushConnector::class, 'sdkVersion'))->setValue(null, '');
+        (new ReflectionProperty(ExpoPushConnector::class, 'sdkVersionResolved'))->setValue(null, true);
+
+        $connector = new ExpoPushConnector();
+
+        $this->assertSame('', $connector->sdkVersion());
+    }
+
     // Internals ----
 
+    private function resolveSdkVersion(string $composerJsonPath): string
+    {
+        return (new ReflectionMethod(ExpoPushConnector::class, 'resolveSdkVersion'))
+            ->invoke(null, $composerJsonPath);
+    }
+
+    private function writeTempFile(string $contents): string
+    {
+        $path = tempnam(sys_get_temp_dir(), 'expo-push-sdk-version-test-');
+
+        file_put_contents($path, $contents);
+
+        $this->tempFiles[] = $path;
+
+        return $path;
+    }
+
     private function findLimit(ExpoPushConnector $connector, string $name): Limit
     {
         try {