Add error handling to SDK version function - #104
Merged
Conversation
liamduckett
requested changes
Sep 3, 2026
liamduckett
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds error handling to cover edge cases that might result in the SDK version caching being skipped and fatal errors being emitted.
Changes
static $versioncache with class-levelself::$sdkVersion/self::$sdkVersionResolvedproperties, so "has this been computed" is tracked independently of the value itself.resolveSdkVersion(string $composerJsonPath): string, guarded withis_readable()and atry/catch (Throwable)around theJSON_THROW_ON_ERRORdecode andInstalledVersions::getPrettyVersion()call, falling back to'unknown'instead of emitting a fatal error.Testing
Added to
tests/Unit/ExpoPushConnectorTest.php:resolveSdkVersion()still resolves the real installed version from the project's actualcomposer.json.'unknown'whencomposer.jsonis missing, or malformed.sdkVersion()returns a cached value without recomputing, including a cached falsy value ('') — the direct regression test for the caching bug.Related Issues
Fixes #90