Skip to content

Optimize floatVectorToFloatArray for performance improvements #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drumath2237 merged 3 commits into from
Mar 23, 2026
+13 −3
Merged

Optimize floatVectorToFloatArray for performance improvements #76

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e848bab
Adjusted floatVectorToFloatArray for faster copy and post-processing
weegeekps Mar 20, 2026
a39a5ed
Fixed formatting.
weegeekps Mar 20, 2026
08629c9
Merge pull request #3 from CesiumGS/weegeekps/faster-memcpy
weegeekps Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions packages/core/lib/spz-wasm/cppBufferUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,28 @@ import type { MainModule, VectorFloat32, VectorUInt8T } from "./build/main";
* create new Float32Array from cpp FloatVector
* @param wasmModule emscripten main module
* @param vec cpp float32 vector
* @param enhancementFunc function accepting a number and returning a number to perform processing
* @returns copied float32 array
*/
export const floatVectorToFloatArray = (
wasmModule: MainModule,
vec: VectorFloat32,
enhancementFunc: (n: number) => number = (n) => n,
enhancementFunc?: (n: number) => number,
): Float32Array => {
const pointer = wasmModule.vf32_ptr(vec);
const size = vec.size();
const floatOffset = pointer >> 2;

const buffer = new Float32Array(wasmModule.HEAPF32.buffer, pointer, size);
const copiedBuffer = buffer.map(enhancementFunc);
const copiedBuffer = wasmModule.HEAPF32.slice(
floatOffset,
floatOffset + size,
);

if (enhancementFunc !== undefined) {
for (let i = 0; i < size; i++) {
copiedBuffer[i] = enhancementFunc(copiedBuffer[i]);
}
}

return copiedBuffer;
};
Expand Down
Loading