ci: update jobs for npm trusted publishing - #86
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's continuous integration configuration related to npm package publishing. It specifically modifies the 'publish:all' script to align with changes in how npm trusted publishing is managed, likely shifting the provenance handling to the CI environment itself rather than an explicit command-line flag. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the publish:all script in package.json. My primary feedback is regarding the removal of NPM_CONFIG_PROVENANCE=true, which seems to disable npm's trusted publishing, contradicting the PR's title and potentially weakening security. I've suggested reverting this. I also noted a minor formatting issue with a missing newline at the end of the file.
No description provided.