Skip to content

ci: update jobs for npm trusted publishing - #86

Merged
drumath2237 merged 2 commits into
mainfrom
feature/#85-trusted-publishing
Mar 24, 2026
Merged

ci: update jobs for npm trusted publishing#86
drumath2237 merged 2 commits into
mainfrom
feature/#85-trusted-publishing

Conversation

@drumath2237

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's continuous integration configuration related to npm package publishing. It specifically modifies the 'publish:all' script to align with changes in how npm trusted publishing is managed, likely shifting the provenance handling to the CI environment itself rather than an explicit command-line flag.

Highlights

  • npm trusted publishing: Removed the explicit 'NPM_CONFIG_PROVENANCE=true' flag from the 'publish:all' script in package.json, indicating an update to how npm trusted publishing is configured or handled in the CI environment.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/release.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@drumath2237 drumath2237 linked an issue Mar 24, 2026 that may be closed by this pull request

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the publish:all script in package.json. My primary feedback is regarding the removal of NPM_CONFIG_PROVENANCE=true, which seems to disable npm's trusted publishing, contradicting the PR's title and potentially weakening security. I've suggested reverting this. I also noted a minor formatting issue with a missing newline at the end of the file.

Comment thread package.json
Comment thread package.json
@drumath2237
drumath2237 merged commit 4d4e1c8 into main Mar 24, 2026
3 checks passed
@drumath2237
drumath2237 deleted the feature/#85-trusted-publishing branch March 24, 2026 11:38
@github-project-automation github-project-automation Bot moved this from 🏗 In progress to ✅ Done in spz-loader Dev Project Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

ci: update jobs for npm trusted publishing

1 participant