Skip to content

Commit 77ce078

Browse files
Merge pull request #35 from ncj-dneg/ncj-dneg-establish-coding-standards
Separate engine and interface packages
2 parents 1c8b6aa + b8585c0 commit 77ce078

138 files changed

Lines changed: 13 additions & 30563 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/quality.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ jobs:
1515
- name: Install quality tools
1616
run: python -m pip install -r requirements-dev.txt
1717
- name: Check formatting and lint
18-
run: ruff check .
19-
- name: Check type hints
20-
run: mypy .
18+
run: ruff check interface run_app.py tools tests --select E,F --ignore E501,F403,F405
19+
- name: Compile interface modules
20+
run: python -m compileall -q interface run_app.py
2121
- name: Check Python file sizes
2222
run: python tools/check_code_standards.py
2323
- name: Check package dependency boundaries

README.md

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,9 @@ creating tokenizers, training small GPT-style language models, benchmarking
1616
checkpoints, exporting model artifacts, and testing local GGUF models in a
1717
streamed Markdown chat interface.
1818

19-
The source is split into the non-Qt `engine/` package and the Qt desktop
20-
`interface/` package. Historical `llm_trainer/` import paths remain available
21-
for compatibility; new application and test code should use the canonical
22-
packages. The dependency direction is one-way: `engine/` never imports
23-
`interface/`, and `interface/` never imports `llm_trainer/`.
19+
The source is split into the non-Qt `engine/` submodule and the Qt desktop
20+
`interface/` package. The dependency direction is one-way: `engine/` never
21+
imports `interface/`.
2422

2523

2624
For development, use Python 3.12 or newer. Distribution builds include a
@@ -86,8 +84,7 @@ The non-Qt command-line engine is available directly:
8684
python -m engine.cli --help
8785
```
8886

89-
`python -m llm_trainer.cli` remains a compatibility alias for existing
90-
automation. Prepare text/PDF/JSONL files:
87+
Prepare text/PDF/JSONL files:
9188

9289
```powershell
9390
python -m engine.cli prepare --input_dir .\examples\tiny_corpus --output_dir .\runs\tiny_data --context_length 16

engine

llm_trainer/__init__.py

Lines changed: 0 additions & 16 deletions
This file was deleted.

llm_trainer/app_logging.py

Lines changed: 0 additions & 116 deletions
This file was deleted.

llm_trainer/backends/__init__.py

Lines changed: 0 additions & 7 deletions
This file was deleted.

llm_trainer/backends/base.py

Lines changed: 0 additions & 33 deletions
This file was deleted.

llm_trainer/backends/local_backend.py

Lines changed: 0 additions & 58 deletions
This file was deleted.

llm_trainer/backends/registry.py

Lines changed: 0 additions & 47 deletions
This file was deleted.

llm_trainer/chat_test.py

Lines changed: 0 additions & 74 deletions
This file was deleted.

0 commit comments

Comments
 (0)