Skip to content

Commit 33b7bbc

Browse files
committed
Renamed menu, fixed doc strings and corrected authorization checks.
1 parent 69dfb41 commit 33b7bbc

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

src/app/app.menus.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { buildMenuStructure } from './shared/menu/menu.structure';
99
import { MenuID } from './shared/menu/menu-id.model';
1010
import { MenuRoute } from './shared/menu/menu-route.model';
1111
import { AccessControlMenuProvider } from './shared/menu/providers/access-control.menu';
12-
import { AddSubObjectsMenuProvider } from './shared/menu/providers/add-sub-objects.menu';
12+
import { AddSubComColMenuProvider } from './shared/menu/providers/add-sub-com-col.menu';
1313
import { AdminSearchMenuProvider } from './shared/menu/providers/admin-search.menu';
1414
import { AuditLogsMenuProvider } from './shared/menu/providers/audit-item.menu';
1515
import { AuditOverviewMenuProvider } from './shared/menu/providers/audit-overview.menu';
@@ -97,7 +97,7 @@ export const MENUS = buildMenuStructure({
9797
MenuRoute.COLLECTION_PAGE,
9898
MenuRoute.ITEM_PAGE,
9999
),
100-
AddSubObjectsMenuProvider.onRoute(
100+
AddSubComColMenuProvider.onRoute(
101101
MenuRoute.COMMUNITY_PAGE,
102102
),
103103
SubmitNewItemMenuProvider.onRoute(

src/app/shared/menu/providers/add-sub-objects.menu.ts renamed to src/app/shared/menu/providers/add-sub-com-col.menu.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ import { PartialMenuSection } from '../menu-provider.model';
2121
import { DSpaceObjectPageMenuProvider } from './helper-providers/dso.menu';
2222

2323
/**
24-
* Menu provider to create the "Edit" option in the DSO edit menu
24+
* Menu provider to create the "Add sub Community" and "Add sub collection" option in the DSO edit menu
2525
*/
2626
@Injectable()
27-
export class AddSubObjectsMenuProvider extends DSpaceObjectPageMenuProvider {
27+
export class AddSubComColMenuProvider extends DSpaceObjectPageMenuProvider {
2828
constructor(
2929
protected authorizationDataService: AuthorizationDataService,
3030
) {
@@ -33,12 +33,12 @@ export class AddSubObjectsMenuProvider extends DSpaceObjectPageMenuProvider {
3333

3434
public getSectionsForContext(dso: DSpaceObject): Observable<PartialMenuSection[]> {
3535
return combineLatest([
36-
this.authorizationDataService.isAuthorized(FeatureID.CanEditMetadata, dso.self),
36+
this.authorizationDataService.isAuthorized(FeatureID.IsCommunityAdmin),
3737
]).pipe(
38-
map(([canEditObject]) => {
38+
map(([isCommunityAdmin]) => {
3939
return [
4040
{
41-
visible: canEditObject,
41+
visible: isCommunityAdmin,
4242
model: {
4343
type: MenuItemType.LINK,
4444
text: 'community.add.sub-community',
@@ -50,7 +50,7 @@ export class AddSubObjectsMenuProvider extends DSpaceObjectPageMenuProvider {
5050
icon: 'plus',
5151
},
5252
{
53-
visible: canEditObject,
53+
visible: isCommunityAdmin,
5454
model: {
5555
type: MenuItemType.LINK,
5656
text: 'community.add.sub-collection',

src/app/shared/menu/providers/submit-new-item.menu.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import { PartialMenuSection } from '../menu-provider.model';
2828
import { DSpaceObjectPageMenuProvider } from './helper-providers/dso.menu';
2929

3030
/**
31-
* Menu provider to create the "Edit" option in the DSO edit menu
31+
* Menu provider to create the "Submit item" option in the DSO edit menu
3232
*/
3333
@Injectable()
3434
export class SubmitNewItemMenuProvider extends DSpaceObjectPageMenuProvider {

0 commit comments

Comments
 (0)