Repository navigation
fix(computer): recover from changed network configuration on restart - #194
Merged
duc15052006-dotcom merged 21 commits intoOct 8, 2026
Merged
duc15052006-dotcom merged 21 commits into
duc15052006-dotcom merged 21 commits into
Conversation
…onfiguration changes
…ent volumes and refuses live replacement
…n Docker lifecycle gate
Owner
Author
|
CI follow-up (2026-10-08): run 37773747816 verified the real supervisor Docker lifecycle suite ran all 16 cases and passed, but overall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
COMPUTER_NETWORKchanges after a desktop/server restart, a previously stopped owned Computer still has its old Docker/PodmanNetworkMode. Before this patch,ensure()returned the new DNS URL without changing its network, making Computer unusable. Inspect the actual network mode, refuse changing a still-running container (fail closed), and replace only the stopped owned container withv:false; named browser profile, workspace and quarantine volumes are preserved. Add pure Docker/Podman network-mode comparisons and a conditional real Docker lifecycle regression covering a live refusal followed by Stop -> network change -> Wake, stable named volume creation times and correct returned URL. Branch based on exact verified RC after PR #193. Requires CI verification; do not merge PR #30 or claim live Windows tested.