[macOS] Respect promo timeout when force showing a promo (debug menu) - #6596
Merged
Conversation
jleandroperez
approved these changes
Sep 1, 2026
jleandroperez
left a comment
Contributor
There was a problem hiding this comment.
✅ Changes look good!
✅ Verified all test scenarios
✅ Verified Autoplay Promo still works as expected
![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1209825025475019/task/1218051322379228?focus=true
Tech Design URL:
CC:
Description
This updates the Promo Queue framework to respect a promo's timeout when force-showing a promo from the debug menu. This force-show debug action allows the promo UI to be viewed separately from the promo queue (e.g. triggers, cooldowns), promo eligibility criteria, and other side effects.
Now, the promo's timeout is respected so the debug action better reflects real promo UI (including auto-dismiss) without having to manually enforce the timeout.
Testing Steps
Impact
Low: Behavior change is limited to debug action (internal tooling)
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Low Risk
Changes are centered on debug force-show and session bookkeeping; production promo evaluation and history updates are unchanged except removing a redundant custom timeout that matched the feature-tip default.
Overview
Debug Force Show in the Promo Queue menu now runs promos through the same
PromoServiceactive-session path as production shows, so timeouts, eligibility retraction, and promo conflicts behave like a real show instead of a one-off delegate call with a manual sleep.Force-show sessions are tagged with
isForceShow: they skip writinglastShown, cooldown/dismissal history, andapplyResulton any outcome, while still drivinghide()and timeout handling viaPromoType.timeoutInterval.For autoplay discoverability, the delegate no longer owns a 5s
displayDurationor sleeps on force show; it presents the permission center and awaits the continuation until the service times out or cleans up.PromoType(.featureTip)still uses the default 5s feature-tip timeout. Force show also skips the shown pixel.Reviewed by Cursor Bugbot for commit d636381. Bugbot is set up for automated code reviews on this repo. Configure here.