Skip to content

Allow Duck Player tabs to burn 'This tab' - #6604

Open
ayoy wants to merge 1 commit into
release/macos/1.206.0from
dominik/fix-fire-dialog-duckplayer
Open

Allow Duck Player tabs to burn 'This tab'#6604
ayoy wants to merge 1 commit into
release/macos/1.206.0from
dominik/fix-fire-dialog-duckplayer

Conversation

@ayoy

@ayoy ayoy commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Task/Issue URL: https://app.asana.com/1/137249556945/project/1204912272578138/task/1218059022048075?focus=true

Description

This change restores the behavior known from the old Fire Dialog. On Duck Player tabs, allow burning current tab
even though tab local history is empty (in this case, allow to close the tab).

Testing Steps

  1. Enable Duck Player, e.g. this way:
Screenshot 2026-09-01 at 17 55 33
  1. Go to YouTube and open a video so that it opens a new tab with Duck Player
  2. Click Fire Button and verify that you can burn current tab, but no history will be deleted. The "Delete & Close" button will be enabled only if "Close tab" checkbox is enabled:
Screenshot 2026-09-01 at 17 57 08

Impact

Low: Minor visual changes, small bug fixes, improvement to existing features


Internal references:

Definition of Done | Engineering Expectations | Tech Design Template


Note

Low Risk
Localized Fire dialog eligibility logic for Duck Player tabs; no changes to data clearing, auth, or persistence.

Overview
The simplified Fire dialog no longer disables This tab when the active tab has no visit history if that tab is Duck Player (e.g. “always open in new tab” from YouTube). Duck Player visits are not stored in tab local history, so the previous guard wrongly forced All data and blocked closing the tab via Fire.

isCurrentTabOptionEnabled now treats Duck Player like a special case alongside hasVisitWithHistoryItems, so users can burn/close the tab even when no history rows would be deleted.

Reviewed by Cursor Bugbot for commit 504322b. Bugbot is set up for automated code reviews on this repo. Configure here.

@ayoy
ayoy requested a review from jleandroperez September 1, 2026 15:57

@jleandroperez jleandroperez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Fix verified, works great!

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants