Allow Duck Player tabs to burn 'This tab' - #6604
Open
ayoy wants to merge 1 commit into
Open
Conversation
jleandroperez
approved these changes
Sep 1, 2026
jleandroperez
left a comment
Contributor
There was a problem hiding this comment.
✅ Fix verified, works great!
![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1204912272578138/task/1218059022048075?focus=true
Description
This change restores the behavior known from the old Fire Dialog. On Duck Player tabs, allow burning current tab
even though tab local history is empty (in this case, allow to close the tab).
Testing Steps
Impact
Low: Minor visual changes, small bug fixes, improvement to existing features
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Low Risk
Localized Fire dialog eligibility logic for Duck Player tabs; no changes to data clearing, auth, or persistence.
Overview
The simplified Fire dialog no longer disables This tab when the active tab has no visit history if that tab is Duck Player (e.g. “always open in new tab” from YouTube). Duck Player visits are not stored in tab local history, so the previous guard wrongly forced All data and blocked closing the tab via Fire.
isCurrentTabOptionEnablednow treats Duck Player like a special case alongsidehasVisitWithHistoryItems, so users can burn/close the tab even when no history rows would be deleted.Reviewed by Cursor Bugbot for commit 504322b. Bugbot is set up for automated code reviews on this repo. Configure here.