Rule update: ddg_mac_desktop (use) CPM magic report: www.mcgeeandco.com - #1492
Rule update: ddg_mac_desktop (use) CPM magic report: www.mcgeeandco.com#1492daxtheduck wants to merge 3 commits into
Conversation
Co-authored-by: Dax <daxtheduck@users.noreply.github.com>
Co-authored-by: Dax <daxtheduck@users.noreply.github.com>
daxtheduck
added
category: rules
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 18a9586. Configure here.
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
| EVAL_SHOPIFY_TEST: () => | ||
| document.cookie.includes('gdpr_cookie_consent=0') || | ||
| (document.cookie.includes('_tracking_consent=') && | ||
| EVAL_SHOPIFY_TEST: () => { |
There was a problem hiding this comment.
The shopify eval should be reverted to it's original state, and we should create a new eval for polaris.
| import generateCMPTests from '../playwright/runner'; | ||
|
|
||
| generateCMPTests('shopify-polaris', ['https://www.mcgeeandco.com/products/calvert-brass-tissue-box-cover']); | ||
| generateCMPTests('shopify-polaris', ['https://mightyvault.com/'], { testOptOut: false, testSelfTest: false }); |
There was a problem hiding this comment.
Why are we skipping opt-out testing? If the rule applies here but can't do opt-out, then we should fix the rule.
Co-authored-by: Dax <daxtheduck@users.noreply.github.com>
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
|
CI run finished. Artifacts ZIP for the review tool |
3 participants
Task/Issue URL: https://app.asana.com/1/137249556945/project/1203268166580279/task/1217183667628060?focus=true
Description:
Automated autoconsent rule update from CPM triage.
Steps to test this PR:
Note
Low Risk
Additive CMP rule and eval snippets only; no changes to core extension logic or security-sensitive paths.
Overview
Adds autoconsent coverage for Shopify’s Polaris customer-privacy widget (
shopify-polaris), including detection, opt-in, opt-out, and verification.The new rule targets
#polaris-css-lockdown-containerand.polaris-consent-widget, with prehide on the lockdown container. Opt-out runs custom evals that click Decline, one-click opt-out, or Okay inside the container’s shadow DOM, then optionally closes the one-click opt-out UI. Success is checked via thepolaris_consent_settingscookie (adsPermittedandnotOptedOutboth false).Playwright CMP tests are added for mcgeeandco.com and mightyvault.com.
Reviewed by Cursor Bugbot for commit c9db185. Bugbot is set up for automated code reviews on this repo. Configure here.