Skip to content

Fix lifecycle management for multiple TurboImageView instances #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MadeinFrance wants to merge 1 commit into from
Closed

Fix lifecycle management for multiple TurboImageView instances #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions android/src/main/java/com/turboimage/TurboImageViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ import com.facebook.react.uimanager.SimpleViewManager
import com.facebook.react.uimanager.ThemedReactContext
import com.facebook.react.uimanager.UIManagerHelper
import com.facebook.react.uimanager.annotations.ReactProp
import java.util.Collections
import java.util.WeakHashMap
import okhttp3.Headers
import com.turboimage.decoder.APNGDecoder
import com.turboimage.events.ProgressEvent
Expand All @@ -34,7 +36,8 @@ import androidx.core.graphics.drawable.toDrawable
class TurboImageViewManager : SimpleViewManager<TurboImageView>(), LifecycleEventListener {
override fun getName() = REACT_CLASS

private lateinit var imageView: TurboImageView
private val attachedViews =
Collections.newSetFromMap(WeakHashMap<TurboImageView, Boolean>())
private var isInBackground = false
override fun getExportedCustomDirectEventTypeConstants(): MutableMap<String, Any>? {
return MapBuilder.of(
Expand All @@ -48,8 +51,7 @@ class TurboImageViewManager : SimpleViewManager<TurboImageView>(), LifecycleEven

override fun createViewInstance(reactContext: ThemedReactContext): TurboImageView {
reactContext.addLifecycleEventListener(this)
imageView = TurboImageView(reactContext)
return imageView
return TurboImageView(reactContext).also { attachedViews.add(it) }
}

override fun onAfterUpdateTransaction(view: TurboImageView) {
Expand All @@ -60,6 +62,7 @@ class TurboImageViewManager : SimpleViewManager<TurboImageView>(), LifecycleEven
override fun onDropViewInstance(view: TurboImageView) {
super.onDropViewInstance(view)
view.dispose()
attachedViews.remove(view)
}

private fun reloadImage(view: TurboImageView) {
Expand Down Expand Up @@ -253,16 +256,18 @@ class TurboImageViewManager : SimpleViewManager<TurboImageView>(), LifecycleEven

override fun onHostResume() {
if (isInBackground) {
reloadImage(imageView)
attachedViews.toList().forEach { reloadImage(it) }
isInBackground = false
}
}

override fun onHostPause() {
imageView.dispose()
attachedViews.toList().forEach { it.dispose() }
isInBackground = true
}

override fun onHostDestroy() {
imageView.dispose()
attachedViews.toList().forEach { it.dispose() }
attachedViews.clear()
}
}
Loading