fix(iOS): clear default NukeUI placeholder background - #433
Merged
duguyihou merged 1 commit intoJan 21, 2026
Merged
Conversation
NukeUI's LazyImageView creates a default placeholderView with secondarySystemBackground color (#1c1c1e in dark mode). This prevents users from customizing the background color via React Native styles, as the placeholder covers the entire view. Setting placeholderView to nil in init allows the parent view's backgroundColor (set via RN style prop) to be visible. Fixes duguyihou#405
Owner
|
This looks great and definitely improves the project. I’ve just merged it. Appreciate your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NukeUI's
LazyImageViewcreates a defaultplaceholderViewwithsecondarySystemBackgroundcolor (#1c1c1ein dark mode).This prevents users from customizing the background color via React Native styles, as the default placeholder covers the entire view before the image loads.
Changes
Setting
placeholderViewtonilininitallows the parent view'sbackgroundColor(set via RN style prop) to be visible.Notes
blurhash,thumbhash,memoryCacheKey) - they still work as expectedindicatorprop - it still works as expectedstylepropFixes #405