fix(android): avoid redundant image reloads - #442
Merged
duguyihou merged 2 commits intoJul 22, 2026
Conversation
Contributor
Author
|
In case of this is the extract from our production app in Playstore. |
duguyihou
added a commit
to tss-ashishmishra/react-native-turbo-image
that referenced
this pull request
Jul 23, 2026
Reconciles this branch's shared-OkHttpClient/ImageLoader fix (duguyihou#440) with main's independently-merged duguyihou#442, which added networkObserverEnabled(false) and load-signature skip-reload logic touching the same reloadImage()/ onDropViewInstance() code. Keeps both fixes: main's networkObserverEnabled(false) is carried onto the shared ImageLoader as defense-in-depth (it already disables the ConnectivityManager callback directly), while this branch's loader/client sharing still fixes the connection-pooling and memory-bloat half of duguyihou#440 that networkObserverEnabled(false) alone didn't address. Skip-reload signature tracking and progress-listener registration coexist unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid scheduling another Android image request when the effective image configuration is unchanged and the previous request already completed successfully.
Repeated React updates and view transactions should not reload an image when its source, headers, cache policy, placeholders, transformations, and layout inputs are unchanged.
Changes
TurboImageView.Directly addresses the same problem I have seen here #440