fix(android): share OkHttpClient and ImageLoader across image loads (fatal TooManyRequestsException) - #443
Merged
duguyihou merged 2 commits intoJul 23, 2026
Conversation
Every reloadImage() built a new OkHttpClient and a new Coil ImageLoader to attach a view-specific ProgressInterceptor. Each ImageLoader registers a ConnectivityManager network callback; Android caps an app at 100, so rendering ~100 images crashes with a fatal TooManyRequestsException. Each OkHttpClient also owns its own thread + connection pool, causing memory bloat under image-heavy scrolling. Fix: one shared OkHttpClient and at most two shared ImageLoaders (one per respectCacheHeaders value). onProgress is preserved: each request is tagged with the view tag via an internal header that ProgressInterceptor strips before the request hits the network, and the matching listener is resolved from a ConcurrentHashMap registry (registered on load, unregistered in onDropViewInstance). Fixes duguyihou#440 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Reconciles this branch's shared-OkHttpClient/ImageLoader fix (duguyihou#440) with main's independently-merged duguyihou#442, which added networkObserverEnabled(false) and load-signature skip-reload logic touching the same reloadImage()/ onDropViewInstance() code. Keeps both fixes: main's networkObserverEnabled(false) is carried onto the shared ImageLoader as defense-in-depth (it already disables the ConnectivityManager callback directly), while this branch's loader/client sharing still fixes the connection-pooling and memory-bloat half of duguyihou#440 that networkObserverEnabled(false) alone didn't address. Skip-reload signature tracking and progress-listener registration coexist unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #440 —
reloadImage()built a newOkHttpClientand a new CoilImageLoaderon every image load (the per-viewProgressInterceptorwas the reason). Consequences in image-heavy apps:ImageLoaderregisters aConnectivityManagernetwork callback. Android caps an app at 100 callbacks, so rendering ~100 images crashes with a fatalandroid.net.ConnectivityManager$TooManyRequestsException(frequently surfacing on an unrelated thread, because the cap is app-wide).OkHttpClientowns its own dispatcher, thread, and connection pool — memory bloat and GC pressure under fast scrolling, up toOutOfMemoryError.Approach
One shared
OkHttpClientand at most two sharedImageLoaders (one perrespectCacheHeadersvalue, driven bycachePolicy), built lazily over the Coil singleton withapplicationContext.onProgresskeeps working:X-TurboImage-View-Tag) added in the Coil request builder.ProgressInterceptorreads and strips the header before the request reaches the network, then resolves the listener from a newProgressListenersregistry (ConcurrentHashMap<Int, ProgressListener>).onDropViewInstance, so no view leaks.Behavior is otherwise unchanged:
newBuilder()over the Coil singleton preserves the same defaults the per-load code inherited, and headers don't participate in Coil's default cache keys, so cache behavior is unaffected.Testing
patch-packagepatch in a large e-commerce app (~80–90% image content): the exact browsing flow that previously crashed withTooManyRequestsExceptionevery session survived 20+ consecutive sessions crash-free, and the OOM/GC-pressure symptoms disappeared.