Skip to content

Commit ebc2a56

Browse files
author
Eli Davidson
committed
test(integ): correct baseline failure docstring, log cleanup failures
Live verification of both integ tests in both directions: - With fix: 2 passed (38s) - Baseline v3.16.0: 2 failed as intended. no_s3 test failed at the HubAccessConfig assertion (CreateModel accepted the gated gemma-2b request without HubAccessConfig; the endpoint then failed asynchronously). Aliased test failed at JumpStartConfig validation (hub_content_name field does not exist on baseline). Corrections from the live run: the no_s3 docstring claimed a synchronous CreateModel ValidationException, but the deterministic failure signal is the HubAccessConfig assertion. Cleanup except block now logs failures instead of silently swallowing them (three Failed-status endpoints leaked during verification runs and were deleted manually). --- X-AI-Prompt: Run both directions live now X-AI-Tool: meshclaw
1 parent 1ae5490 commit ebc2a56

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

‎sagemaker-serve/tests/integ/test_private_hub_artifact_resolution.py‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -389,8 +389,8 @@ def _deploy_and_assert_hub_access_config(
389389
):
390390
try:
391391
op(**kwargs)
392-
except Exception:
393-
pass
392+
except Exception as e:
393+
logger.warning("Cleanup failed for %s: %s", kwargs, e)
394394

395395

396396
@pytest.mark.slow_test
@@ -401,8 +401,10 @@ def test_deploy_with_no_s3_execution_role(
401401
S3 permissions. Passes only when the SDK attaches HubAccessConfig to
402402
the CreateModel call (SageMaker brokers artifact access via the hub).
403403
404-
On v3.16.0 this fails at CreateModel with a ValidationException:
405-
'Could not access model data at s3://jumpstart-cache-prod-...'.
404+
Verified against the v3.16.0 baseline: fails at the HubAccessConfig
405+
assertion (the created Model resource has no
406+
S3DataSource.HubAccessConfig, so artifact access is not brokered and
407+
the endpoint cannot serve without public-bucket S3 permissions).
406408
"""
407409
_deploy_and_assert_hub_access_config(
408410
hub_name=private_hub,

0 commit comments

Comments
 (0)