Fix default history depth in examples - #6534
Open
raulojeda22 wants to merge 1 commit into
Open
raulojeda22 wants to merge 1 commit into
raulojeda22 wants to merge 1 commit into
Conversation
Signed-off-by: Raül Ojeda Gandia <raulojeda@eprosima.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We used to have a default limit in max_samples_per_instance of 400, until this PR changed it to 0 (unlimited): #6261
These examples used that value to set the depth if the param
-swas not set (samples), so with default values, just a publisher and a subscriber, the example failed with this error:This PR fixes this issue by adding a constant with a default depth to the examples for when the samples parameter is not set.
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist