Skip to content

Commit 11bdace

Browse files
committed
update changelog and improve test
1 parent e4550cf commit 11bdace

2 files changed

Lines changed: 22 additions & 5 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,17 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
1010

1111
- `<SilkActivityControl />`, `<ActivityExecutionErrorReportModal />`
1212
- support `aria-label` and `aria-labelledby` for naming activity error report dialogs without a visible title
13+
- support `fullScreenTogglerTexts` to set localized texts for the full screen toggler of the error report dialog
14+
- `<SimpleDialog />`
15+
- `fullScreenTogglerTexts` property: sets the texts of the full screen toggler for the `maximize` and `minimize` state, used as `title` and accessible name of the button
16+
17+
### Changed
18+
19+
- `<SimpleDialog />`
20+
- the full screen toggler has an accessible name and a `title` now, the default texts are "Show in full screen" and "Exit full screen", use `fullScreenTogglerTexts` to localize them
21+
- `<SilkActivityControl />`, `<ActivityExecutionErrorReportModal />`
22+
- error report dialogs without title, `aria-label` and `aria-labelledby` get a fallback accessible name, `translate("showErrorReport")` in `<SilkActivityControl />` and "Activity execution error report" in `<ActivityExecutionErrorReportModal />`
23+
- the error report dialog uses the full screen toggler of `<SimpleDialog />` instead of an own implementation
1324

1425
## [26.2.1] - 2026-11-02
1526

‎src/cmem/ActivityControl/tests/SilkActivityControl.test.tsx‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,17 @@ describe("SilkActivityControl error report", () => {
7575

7676
it("uses the translated `showErrorReport` text as fallback name for a titleless error report dialog", async () => {
7777
const warnSpy = jest.spyOn(console, "warn").mockImplementation(() => undefined);
78-
const { openErrorReport } = renderFailedActivity({ title: "", "aria-label": "" });
79-
openErrorReport();
80-
expect(await screen.findByRole("dialog", { name: "showErrorReport" })).toHaveAttribute("aria-modal", "true");
81-
expect(warnSpy).not.toHaveBeenCalled();
82-
warnSpy.mockRestore();
78+
try {
79+
const { openErrorReport } = renderFailedActivity({ title: "", "aria-label": "" });
80+
openErrorReport();
81+
expect(await screen.findByRole("dialog", { name: "showErrorReport" })).toHaveAttribute(
82+
"aria-modal",
83+
"true",
84+
);
85+
expect(warnSpy).not.toHaveBeenCalled();
86+
} finally {
87+
warnSpy.mockRestore();
88+
}
8389
});
8490

8591
it("forwards the full screen toggler texts to the error report dialog", async () => {

0 commit comments

Comments
 (0)