Skip to content

Commit 190403c

Browse files
Replace root import by direct component imports to avoid circular dependencies
1 parent 6f0aa31 commit 190403c

8 files changed

Lines changed: 58 additions & 67 deletions

File tree

‎src/cmem/ActivityControl/SilkActivityControl.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import React, { useEffect, useRef, useState } from "react";
22
import { Intent } from "@blueprintjs/core/src/common/intent";
33

4-
import { Icon, Spacing } from "../../";
54
import { IntentTypes } from "../../common/Intent";
5+
import { Icon } from "../../components/Icon/Icon";
66
import { TestableComponent } from "../../components/interfaces";
7+
import { Spacing } from "../../components/Separation/Spacing";
78
import { ElapsedDateTimeDisplay, ElapsedDateTimeDisplayUnits } from "../DateTimeDisplay/ElapsedDateTimeDisplay";
89

910
import { SilkActivityStatusConcrete, SilkActivityStatusProps } from "./ActivityControlTypes";

‎src/cmem/react-flow/StickyNoteModal/StickyNoteModal.tsx‎

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,15 @@
11
import React from "react";
22

33
import getColorConfiguration from "../../../common/utils/getColorConfiguration";
4-
import { CodeEditor } from "../../../extensions";
4+
import { Button } from "../../../components/Button/Button";
5+
import { SimpleDialog, type SimpleDialogProps } from "../../../components/Dialog/SimpleDialog";
6+
import { FieldItem } from "../../../components/Form/FieldItem";
7+
import { Icon } from "../../../components/Icon/Icon";
8+
import Tag from "../../../components/Tag/Tag";
9+
import TagList from "../../../components/Tag/TagList";
10+
import { CodeEditor, type CodeEditorProps } from "../../../extensions/codemirror/CodeMirror";
511
import { ReactFlowHotkeyContext } from "../extensions/ReactFlowHotkeyContext";
612

7-
import {
8-
Button,
9-
CodeEditorProps,
10-
FieldItem,
11-
Icon,
12-
SimpleDialog,
13-
SimpleDialogProps,
14-
Tag,
15-
TagList,
16-
} from "./../../../index";
17-
1813
export type StickyNoteModalTranslationKeys = "modalTitle" | "noteLabel" | "colorLabel" | "saveButton" | "cancelButton";
1914

2015
export type StickyNoteMetadataType = { note: string; color: string };

‎src/components/AutoSuggestion/AutoSuggestion.tsx‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,13 @@ import { debounce } from "lodash";
77
import { IntentTypes } from "../../common/Intent";
88
import { CLASSPREFIX as eccgui } from "../../configuration/constants";
99
import { SupportedCodeEditorModes } from "../../extensions/codemirror/hooks/useCodemirrorModeExtension.hooks";
10+
import { ContextOverlay } from "../ContextOverlay/ContextOverlay";
11+
import { FieldItem } from "../Form/FieldItem";
12+
import { IconButton } from "../Icon/IconButton";
13+
import { Spinner } from "../Spinner/Spinner";
14+
import { Toolbar } from "../Toolbar/Toolbar";
15+
import { ToolbarSection } from "../Toolbar/ToolbarSection";
1016

11-
import { ContextOverlay, FieldItem, IconButton, Spinner, Toolbar, ToolbarSection } from "./../../";
1217
import { markText, removeMarkFromText } from "./extensions/markText";
1318
import { AutoSuggestionList } from "./AutoSuggestionList";
1419
//custom components

‎src/components/AutoSuggestion/AutoSuggestionList.tsx‎

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,16 @@ import React from "react";
22
import { compute } from "compute-scroll-into-view";
33

44
import { CLASSPREFIX as eccgui } from "../../configuration/constants";
5-
6-
import {
7-
Highlighter,
8-
Menu,
9-
MenuItem,
10-
OverflowText,
11-
OverviewItem,
12-
OverviewItemDescription,
13-
OverviewItemLine,
14-
Spacing,
15-
Spinner,
16-
Tooltip,
17-
} from "./../../";
5+
import { Menu } from "../Menu/Menu";
6+
import { MenuItem } from "../Menu/MenuItem";
7+
import { OverviewItem } from "../OverviewItem/OverviewItem";
8+
import { OverviewItemDescription } from "../OverviewItem/OverviewItemDescription";
9+
import { OverviewItemLine } from "../OverviewItem/OverviewItemLine";
10+
import { Spacing } from "../Separation/Spacing";
11+
import { Spinner } from "../Spinner/Spinner";
12+
import { Tooltip } from "../Tooltip/Tooltip";
13+
import { Highlighter } from "../Typography/Highlighter";
14+
import { OverflowText } from "../Typography/OverflowText";
1815
import { CodeAutocompleteFieldSuggestionWithReplacementInfo } from "./AutoSuggestion";
1916

2017
export interface AutoSuggestionListProps extends Omit<React.HTMLAttributes<HTMLDivElement>, "children"> {

‎src/components/AutocompleteField/AutoCompleteField.tsx‎

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,14 @@ import { Suggest as BlueprintSuggest } from "@blueprintjs/select";
77

88
import { preventReactFlowDragClass } from "../../cmem/react-flow/ReactFlow/constants";
99
import { CLASSPREFIX as eccgui } from "../../configuration/constants";
10-
import {
11-
ContextOverlayProps,
12-
Highlighter,
13-
IconButton,
14-
Menu,
15-
MenuItem,
16-
Notification,
17-
OverflowText,
18-
Spinner,
19-
} from "../../index";
10+
import type { ContextOverlayProps } from "../ContextOverlay/ContextOverlay";
11+
import { IconButton } from "../Icon/IconButton";
12+
import { Menu } from "../Menu/Menu";
13+
import { MenuItem } from "../Menu/MenuItem";
14+
import { Notification } from "../Notification/Notification";
15+
import { Spinner } from "../Spinner/Spinner";
16+
import { Highlighter } from "../Typography/Highlighter";
17+
import { OverflowText } from "../Typography/OverflowText";
2018

2119
import { SuggestFieldItemRendererModifierProps } from "./interfaces";
2220

‎src/components/MultiSelect/MultiSelect.tsx‎

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,13 @@ import { uniqBy } from "lodash";
1111
import { IntentBlueprint } from "../../common/Intent";
1212
import { removeExtraSpaces } from "../../common/utils/stringUtils";
1313
import { CLASSPREFIX as eccgui } from "../../configuration/constants";
14+
import type { ContextOverlayProps } from "../ContextOverlay/ContextOverlay";
15+
import { IconButton } from "../Icon/IconButton";
1416
import { TestableComponent } from "../interfaces";
15-
import { MenuItemProps } from "../Menu/MenuItem";
16-
17-
import {
18-
ContextOverlayProps,
19-
Highlighter,
20-
highlighterUtils,
21-
IconButton,
22-
MenuItem,
23-
OverflowText,
24-
Spinner,
25-
} from "./../../index";
17+
import { MenuItem, type MenuItemProps } from "../Menu/MenuItem";
18+
import { Spinner } from "../Spinner/Spinner";
19+
import { Highlighter, highlighterUtils } from "../Typography/Highlighter";
20+
import { OverflowText } from "../Typography/OverflowText";
2621

2722
export interface MultiSuggestFieldSelectionProps<T> {
2823
newlySelected?: T;

‎src/components/NotAvailable/NotAvailable.tsx‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
import React from "react";
22

3-
import { CLASSPREFIX as eccgui, Tag, TagProps, Tooltip, TooltipProps } from "../../index";
3+
import { CLASSPREFIX as eccgui } from "../../configuration/constants";
44
import { TestableComponent } from "../interfaces";
5+
import Tag, { type TagProps } from "../Tag/Tag";
6+
import { Tooltip, type TooltipProps } from "../Tooltip/Tooltip";
57
export interface NotAvailableProps
68
extends TestableComponent, Pick<TagProps, "icon" | "className">, Pick<TooltipProps, "intent"> {
79
/**

‎src/components/VisualTour/VisualTour.tsx‎

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,23 @@
11
import React from "react";
22
import { createPortal } from "react-dom";
33

4+
import { Markdown } from "../../cmem/markdown/Markdown";
45
import { CLASSPREFIX as eccgui } from "../../configuration/constants";
5-
import {
6-
Badge,
7-
Button,
8-
Card,
9-
CardActions,
10-
CardActionsAux,
11-
CardContent,
12-
CardHeader,
13-
CardOptions,
14-
CardTitle,
15-
DecoupledOverlay,
16-
IconButton,
17-
Markdown,
18-
ModalSize,
19-
SimpleDialog,
20-
Spacing,
21-
TooltipSize,
22-
} from "../../index";
6+
import { Badge } from "../Badge/Badge";
7+
import { Button } from "../Button/Button";
8+
import { Card } from "../Card/Card";
9+
import { CardActions } from "../Card/CardActions";
10+
import { CardActionsAux } from "../Card/CardActionsAux";
11+
import { CardContent } from "../Card/CardContent";
12+
import { CardHeader } from "../Card/CardHeader";
13+
import { CardOptions } from "../Card/CardOptions";
14+
import { CardTitle } from "../Card/CardTitle";
15+
import { DecoupledOverlay } from "../DecoupledOverlay/DecoupledOverlay";
16+
import type { ModalSize } from "../Dialog/Modal";
17+
import { SimpleDialog } from "../Dialog/SimpleDialog";
18+
import { IconButton } from "../Icon/IconButton";
19+
import { Spacing } from "../Separation/Spacing";
20+
import type { TooltipSize } from "../Tooltip/Tooltip";
2321

2422
export interface VisualTourProps {
2523
/** The steps of the tour. */

0 commit comments

Comments
 (0)