Skip to content

Fixed the baked state of the onChange function and disabled prop in <CodeMirror /> component (CMEM-7195) - #373

Merged
haschek merged 1 commit into
developfrom
feature/badges-config-CMEM-7195
Mar 10, 2026
Merged

haschek merged 1 commit into
developfrom
feature/badges-config-CMEM-7195

Conversation

@fiorsaoirse

@fiorsaoirse fiorsaoirse commented Feb 27, 2026 •

Copy link
Copy Markdown
Contributor

The problem: the onChange function and disabled state were baked on the component's mounting, so the function from the closure was used as a callback and the disabled param could be not actual. See the attachment in the ticket for more details.

@fiorsaoirse
fiorsaoirse requested a review from haschek February 27, 2026 08:47
@fiorsaoirse fiorsaoirse changed the title Fixed the baked state of the onChange function in <CodeMirror /> component Fixed the baked state of the onChange function in <CodeMirror /> component (CMEM-7195) Feb 27, 2026
@fiorsaoirse fiorsaoirse changed the title Fixed the baked state of the onChange function in <CodeMirror /> component (CMEM-7195) Fixed the baked state of the onChange function and disabled prop in <CodeMirror /> component (CMEM-7195) Feb 27, 2026
@fiorsaoirse
fiorsaoirse force-pushed the feature/badges-config-CMEM-7195 branch from a704385 to 64b97cd Compare March 2, 2026 07:38
…onent

Fixed the baked state of the onChange function in <CodeMirror /> component
@fiorsaoirse
fiorsaoirse force-pushed the feature/badges-config-CMEM-7195 branch from decbe16 to d2f6644 Compare March 9, 2026 14:50
@haschek
haschek merged commit 1a1387c into develop Mar 10, 2026
8 checks passed
@haschek
haschek deleted the feature/badges-config-CMEM-7195 branch March 10, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants