Repository navigation
Fix misused menu roles and MultiSelect popup semantics and keyboard behavior - #437
Open
andreas-schultz wants to merge 23 commits into
Open
andreas-schultz wants to merge 23 commits into
andreas-schultz wants to merge 23 commits into
Conversation
- Use listbox and option roles for autocomplete suggestions. - Remove implicit menu semantics from generic ContextOverlay triggers. - Preserve menu popup semantics for ContextMenu and React Flow tools. - Add regression tests for popup semantics and selection behavior.
- Use combobox, listbox and option semantics with active option tracking. - Label tag removal buttons and announce selection changes. - Prevent duplicate checkmarks and keyboard activation. - Restore input focus on Escape while preserving the filter. - Preserve filters and keep the popup open when toggling existing options. - Clear the filter only when creating a new tag. - Restore normal Tab and Shift+Tab navigation. - Prevent the entire dropdown from being announced on opening.
- Deduplicate supplied, remote and newly created options by ID. - Allow external option updates while preserving remote search results. - Recognise existing entries and remove duplicate creation handlers. - Preserve supplementary details in custom option accessible names. - Cancel pending searches and stop loading when resetting the query.
…ature/improveMenuRoleSupport-CMEM-7707
…ature/improveMenuRoleSupport-CMEM-7707
…MEM-7707 Improve Menu role support (CMEM-7707)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First #440 need to be reviewed/merged.