test(e2e): multi-worker server + robust compare wait - #221
Merged
Merged
Conversation
…te flakiness The full e2e suite (e2e-full.yml, self-hosted with models) ran the 13 Playwright tests against the single-worker demo app, so back-to-back heavy requests queued and timed out. Fixes: - e2e-full.yml starts a dedicated 4-worker uvicorn on :8011 (isolated from the live :8000 demo), waits for readiness, runs the suite, and tears it down. - test_compare_loads_and_loaders_clear waited for the FIRST card image then a fixed 500ms before asserting BOTH images visible; the second card lags under load. Now polls for two non-loading cards with images (no fixed sleep). Validated locally against a 4-worker server: 13/13 passed, twice, ~30s. Closes #212. Signed-off-by: Austin L. <86896075+rvnminers-A-and-N@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kills the full-suite e2e flakiness (#212).
Cause:
e2e-full.ymlran all 13 Playwright tests against the single-worker demo app on :8000, so back-to-back heavy model-inference requests queued and hit their 30–40s waits.Fix:
e2e-full.ymlnow starts a dedicated 4-worker uvicorn on :8011 (isolated from the live :8000 demo), waits for readiness, runs the suite, tears it down.test_compare_loads_and_loaders_clearwaited for the first card's image then a fixed 500 ms before asserting both images visible — the second card lags under load. Now polls for two non-loading cards with images (no fixed sleep).Validated: 13/13 passed twice against a local 4-worker server, ~30 s each (was 1–4 flaky failures).
Closes #212.