File the aroma sweet note under Sweet & bakery, not Other - #259
Merged
Merged
Conversation
The notes picker groups heads into perceptual families and sweeps anything unlisted into an Other bucket so no head is silently dropped. The aroma `sweet` head was never listed, so it landed in Other alongside `odorless` — reading as an uncategorised leftover rather than the deliberate note it is, and sitting oddly far from vanilla/caramel/honey where a flavorist would look for it. `odorless` stays in Other on purpose: it is the absence of a percept, so it has no perceptual family to belong to, and Other is the honest home for it. Found while reconciling the chip pickers against the head roster after the retrain in #258 (164 -> 167 heads). The three heads that newly cleared the AUROC bar — blackberry, fig, magnolia — were already covered by the Fruity and Floral families, so nothing else moved. Signed-off-by: Austin L. <86896075+rvnminers-A-and-N@users.noreply.github.com>
rvnminers-A-and-N
added
area:aroma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notes picker groups heads into perceptual families and sweeps anything unlisted into an Other bucket so no head is silently dropped. The aroma
sweethead was never listed, so it landed in Other next toodorless— reading as an uncategorised leftover rather than the deliberate note it is, and sitting oddly far from vanilla/caramel/honey where a flavorist would look for it.odorlessstays in Other on purpose: it's the absence of a percept, so it has no perceptual family to belong to.Found while reconciling the chip pickers against the head roster after the retrain in #258 (164 → 167 heads). The three heads that newly cleared the AUROC bar —
blackberry,fig,magnolia— were already covered by Fruity and Floral, so nothing else moved.Verified: every one of the 167 aroma heads now resolves to a named family except
odorless, and no term appears in two families.