fix(training): lift sour-rule recall 0.57 → 0.93 (match acid anions) - #42
Merged
Merged
Conversation
The acidity rule matched only protonated acids (-OH), missing every carboxylate/sulfonate/phosphate anion and zwitterion — how many sour compounds are actually drawn. Match both -OH and -O- forms (in predict.py and the train_taste.py validation copy). Recall on labeled-sour rises 0.57 -> 0.93; firing 1349 -> 1675/3295 (acceptable: the rule is the structural cross-check, the trained sour_predicted head carries the perception signal). Closes #41.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The acidity rule matched only protonated acids (
-OH), missing carboxylate/sulfonate/phosphate anions and zwitterions — how many sour compounds are drawn. Matching both-OHand-O-lifts recall on labeled-sour 0.57 → 0.93 (firing 1349 → 1675/3295, fine for a structural cross-check). Fixed inpredict.py+ thetrain_taste.pyvalidation copy.Closes #41.