Pull the whole public-domain odor corpus + fix name display - #81
Merged
Merged
Conversation
build_odor_notes.py gains --pubchem-all: pulls the ENTIRE public-domain PubChem odor set via the annotations API (odor text + source + CID inline, all pages), filtered to HSDB/Haz-Map/CAMEO, resolving CIDs to InChIKeys in batches. ~20 requests instead of a 3k-molecule crawl; odor_notes.parquet goes from ~190 to ~2,260 molecules. Name fix: PubChem's Title for a flattened structure is often the systematic name (cinnamaldehyde -> '3-Phenylprop-2-Enal'), which read as the IUPAC name shown twice. Now api/names uses the user's typed name as the common name when they searched by name, and the workbench never renders common when it equals the IUPAC string. Signed-off-by: Austin L. <86896075+rvnminers-A-and-N@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--pubchem-all: pulls the entire public-domain PubChem odor set via the annotations API (inline text+source+CID, all pages), filtered to HSDB/Haz-Map/CAMEO, batched CID→InChIKey. odor_notes.parquet ~190 → ~2,260 molecules — the training corpus for the descriptor model.Name fix: flattened-structure Titles are often systematic (cinnamaldehyde → '3-Phenylprop-2-Enal'), which looked like the IUPAC name doubled. Now the typed name is used as the common name, and the display never repeats the same string.