Enable compiler's sanitizers [thread,ub, and address] - #1155
Open
zmostafa wants to merge 17 commits into
Open
Conversation
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
zmostafa
marked this pull request as draft
October 27, 2025 14:25
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
zmostafa
marked this pull request as ready for review
October 27, 2025 14:33
zmostafa
force-pushed
the
iox2-957-add-thread-sanitizers
branch
from
October 27, 2025 15:11
32c5fd7 to
777bd78
Compare
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
zmostafa
force-pushed
the
iox2-957-add-thread-sanitizers
branch
from
October 27, 2025 15:15
777bd78 to
f404393
Compare
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
==========================================
+ Coverage 77.90% 77.92% +0.02%
==========================================
Files 360 360
Lines 38788 38788
Branches 807 807
==========================================
+ Hits 30217 30225 +8
+ Misses 7932 7924 -8
Partials 639 639
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
zmostafa
force-pushed
the
iox2-957-add-thread-sanitizers
branch
from
October 27, 2025 17:27
a935791 to
6aba344
Compare
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
zmostafa
force-pushed
the
iox2-957-add-thread-sanitizers
branch
from
October 27, 2025 19:00
72009f0 to
129898c
Compare
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
zmostafa
force-pushed
the
iox2-957-add-thread-sanitizers
branch
2 times, most recently
from
October 27, 2025 20:18
94f1b81 to
05b2cc8
Compare
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
zmostafa
force-pushed
the
iox2-957-add-thread-sanitizers
branch
from
October 27, 2025 20:21
79fa05f to
8993861
Compare
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
zmostafa
force-pushed
the
iox2-957-add-thread-sanitizers
branch
from
October 27, 2025 20:26
8993861 to
c65e7c9
Compare
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
zmostafa
commented
Oct 27, 2025
| set(ICEORYX2_TEST_CXX_FLAGS ${ICEORYX2_TEST_CXX_FLAGS} ${ICEORYX2_SANITIZER_FLAGS} CACHE INTERNAL "") | ||
|
|
||
| # Sanitizer flags must also be added to linker flags | ||
| set(ICEORYX2_LINK_FLAGS ${ICEORYX2_LINK_FLAGS} ${ICEORYX2_SANITIZER_FLAGS} CACHE INTERNAL "") |
Contributor
Author
There was a problem hiding this comment.
todo: this can be removed, after fixing the typo the linker already includes sanitizer flags
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
Signed-off-by: Ziad Mostafa <mohammedziad.badr@gmail.com>
Contributor
Author
|
@elBoberido would be nice to get your feedback about this PR and the test failure I am getting while running the tests with sanitizers, also I had issues with macos too. I tried to match sanitizers in iceoryx as much as I can and not sure what might be wrong or still missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Pre-Review Checklist for the PR Author
Convert to draft)SPDX-License-Identifier: Apache-2.0 OR MITiox2-123-introduce-posix-ipc-example)[#123] Add posix ipc example)task-list-completed)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #957