Skip to content

[#1910] unique id generator concept - #1957

Open
FerdinandSpitzschnueffler wants to merge 18 commits into
eclipse-iceoryx:mainfrom
ekxide:iox2-1910-unique-system-id-concept
Open

[#1910] unique id generator concept#1957
FerdinandSpitzschnueffler wants to merge 18 commits into
eclipse-iceoryx:mainfrom
ekxide:iox2-1910-unique-system-id-concept

Conversation

@FerdinandSpitzschnueffler

Copy link
Copy Markdown
Contributor

Notes for Reviewer

This PR adds a UniqueIdGenerator concept to allow different implementations for generating unique IDs.

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
    • Commit messages have the issue ID ([#123] Add posix ipc example)
    • Keep in mind to use the same email that was used to sign the Eclipse Contributor Agreement
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes

PR Reviewer Reminders

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

References

Closes #1910

@FerdinandSpitzschnueffler
FerdinandSpitzschnueffler force-pushed the iox2-1910-unique-system-id-concept branch from cdf145d to a3a97b7 Compare September 1, 2026 09:00
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.82403% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.47%. Comparing base (c98c64d) to head (a3a97b7).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...eoryx2/src/unique_id_generator/unique_system_id.rs 40.74% 16 Missing ⚠️
iceoryx2/src/identifiers.rs 54.83% 14 Missing ⚠️
iceoryx2/src/service/resource/mod.rs 33.33% 12 Missing ⚠️
iceoryx2/src/unique_id_generator/mod.rs 76.92% 6 Missing ⚠️
iceoryx2/src/service/mod.rs 80.00% 2 Missing ⚠️
iceoryx2-cxx/src/unique_node_id.cpp 0.00% 1 Missing ⚠️
iceoryx2-gateway/gateway/src/builder.rs 0.00% 1 Missing ⚠️
...ervices/discovery/src/service_discovery/service.rs 75.00% 1 Missing ⚠️
iceoryx2/src/node/mod.rs 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
- Coverage   76.53%   76.47%   -0.07%     
==========================================
  Files         452      455       +3     
  Lines       46046    46144      +98     
  Branches     1489     1488       -1     
==========================================
+ Hits        35243    35288      +45     
- Misses       9541     9594      +53     
  Partials     1262     1262              
Flag Coverage Δ
CPP 62.66% <66.66%> (+0.05%) ⬆️
Rust 76.32% <76.82%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
iceoryx2-bb/posix/src/unique_system_id.rs 79.77% <ø> (-15.74%) ⬇️
iceoryx2-cxx/include/iox2/unique_node_id.hpp 100.00% <100.00%> (ø)
...2-gateway/backend/src/types/service_description.rs 92.00% <100.00%> (ø)
...eoryx2-gateway/gateway/src/discovery/subscriber.rs 53.70% <100.00%> (ø)
iceoryx2-gateway/gateway/src/gateway.rs 80.97% <ø> (ø)
iceoryx2/src/active_request.rs 92.85% <100.00%> (ø)
iceoryx2/src/node/global_management_segment.rs 88.67% <ø> (ø)
iceoryx2/src/port/client.rs 93.02% <100.00%> (+0.02%) ⬆️
iceoryx2/src/port/listener.rs 90.40% <100.00%> (+0.07%) ⬆️
iceoryx2/src/port/notifier.rs 85.82% <100.00%> (-1.02%) ⬇️
... and 27 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UniqueSystemId concept

1 participant