Skip to content

fix: send Malformed Packet CONNACK for username parse error in MQTT 5.0 #3710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liooooo29 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Open

fix: send Malformed Packet CONNACK for username parse error in MQTT 5.0 #3710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/handle_connect.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,9 @@ static int read_and_verify_client_credentials_from_packet(struct mosquitto *cont
if(username_flag){
rc = set_username_from_packet(context, username, clientid);
if(rc != MOSQ_ERR_SUCCESS){
if(context->protocol == mosq_p_mqtt5){
send__connack(context, 0, MQTT_RC_MALFORMED_PACKET, NULL);
}
return rc;
}
}else{
Expand Down