Conversation
In 2.1.x, session_expiry__check() was added to broker startup and runs before bridge__start_all(). This causes restored outgoing bridge sessions to be incorrectly expired if persistent_client_expiration has passed, silently discarding the bridge's offline message queue. Add a bridge guard in session_expiry__check() to skip outgoing bridge sessions, consistent with the existing 'Outgoing bridge connection never expire' guard in context__disconnect(). Fixes eclipse-mosquitto#3728 Signed-off-by: v1rtu3x <marktamas28@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 2.1.x, session_expiry__check() was added to broker startup and runs
before bridge__start_all(). This causes restored outgoing bridge sessions
to be incorrectly expired if persistent_client_expiration has passed,
silently discarding the bridge's offline message queue.
Add a bridge guard in session_expiry__check() to skip outgoing bridge
sessions, consistent with the existing 'Outgoing bridge connection never
expire' guard in context__disconnect().
Fixes #3728
make testwith your changes locally?