Skip to content

Fix bridge session expiry at startup before bridges are started - #3732

Open
v1rtu3x wants to merge 1 commit into
eclipse-mosquitto:masterfrom
v1rtu3x:fix-3728-fixes
Open

v1rtu3x wants to merge 1 commit into
eclipse-mosquitto:masterfrom
v1rtu3x:fix-3728-fixes

Conversation

@v1rtu3x

@v1rtu3x v1rtu3x commented Sep 3, 2026

Copy link
Copy Markdown

In 2.1.x, session_expiry__check() was added to broker startup and runs
before bridge__start_all(). This causes restored outgoing bridge sessions
to be incorrectly expired if persistent_client_expiration has passed,
silently discarding the bridge's offline message queue.

Add a bridge guard in session_expiry__check() to skip outgoing bridge
sessions, consistent with the existing 'Outgoing bridge connection never
expire' guard in context__disconnect().

Fixes #3728

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

In 2.1.x, session_expiry__check() was added to broker startup and runs
before bridge__start_all(). This causes restored outgoing bridge sessions
to be incorrectly expired if persistent_client_expiration has passed,
silently discarding the bridge's offline message queue.

Add a bridge guard in session_expiry__check() to skip outgoing bridge
sessions, consistent with the existing 'Outgoing bridge connection never
expire' guard in context__disconnect().

Fixes eclipse-mosquitto#3728

Signed-off-by: v1rtu3x <marktamas28@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.1: restored bridge session is expired at startup, before bridges are started

1 participant