Conversation
In 2.1.x, session_expiry__check() was added to broker startup and runs before bridge__start_all(). This causes restored outgoing bridge sessions to be incorrectly expired if persistent_client_expiration has passed, silently discarding the bridge's offline message queue. Add a bridge guard in session_expiry__check() to skip outgoing bridge sessions, consistent with the existing 'Outgoing bridge connection never expire' guard in context__disconnect(). Fixes eclipse-mosquitto#3728 Signed-off-by: v1rtu3x <marktamas28@gmail.com>
RFC 6455 states that a server MUST close the connection upon receiving a frame that is not masked from a client. The built-in WebSocket transport previously accepted unmasked frames, which could also lead to silent payload corruption due to stale masking keys. Fixes eclipse-mosquitto#3705
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3705
The built-in WebSocket transport accepted unmasked client frames, which violates RFC 6455 §5.1. It also meant an unmasked frame after a masked one would be XORed with a stale key and silently corrupted.
Add a check in
read_ws_payloadlen_short()to reject frames withmask == 0, usingdisconnect_reason = 0xEAanderrno = EPROTOto match the existing error style.Tested with the reproducer from #3705:
All conformant clients already mask, so this should not break anything legitimate.