Skip to content

Change the write-side check to match the read-side and the OpenSSL API - #3738

Open
ValentinChernovNTQ wants to merge 1 commit into
eclipse-mosquitto:fixesfrom
ValentinChernovNTQ:fix/issue-3354
Open

ValentinChernovNTQ wants to merge 1 commit into
eclipse-mosquitto:fixesfrom
ValentinChernovNTQ:fix/issue-3354

Conversation

@ValentinChernovNTQ

Copy link
Copy Markdown

File: lib/net_mosq.c, function net__write(): Change the write-side check to match the read-side and the OpenSSL API contract

This is a minimal, symmetric, low-risk change: it makes net__write() handle SSL_write() failures exactly the way net__read() already handles SSL_read() failures, using the same, already-tested net__handle_ssl() path.

Fixes: #3354

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

…I contract

File: lib/net_mosq.c, function net__write()

This is a minimal, symmetric, low-risk change: it makes net__write() handle SSL_write()
failures exactly the way net__read() already handles SSL_read() failures, using the
same, already-tested net__handle_ssl() path.

Fixes: eclipse-mosquitto#3354

Signed-off-by: Valentin Chernov <valentin.chernov@ntq-solution.com.vn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant