Change the write-side check to match the read-side and the OpenSSL API - #3738
Open
ValentinChernovNTQ wants to merge 1 commit into
Open
ValentinChernovNTQ wants to merge 1 commit into
ValentinChernovNTQ wants to merge 1 commit into
Conversation
…I contract File: lib/net_mosq.c, function net__write() This is a minimal, symmetric, low-risk change: it makes net__write() handle SSL_write() failures exactly the way net__read() already handles SSL_read() failures, using the same, already-tested net__handle_ssl() path. Fixes: eclipse-mosquitto#3354 Signed-off-by: Valentin Chernov <valentin.chernov@ntq-solution.com.vn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File: lib/net_mosq.c, function net__write(): Change the write-side check to match the read-side and the OpenSSL API contract
This is a minimal, symmetric, low-risk change: it makes net__write() handle SSL_write() failures exactly the way net__read() already handles SSL_read() failures, using the same, already-tested net__handle_ssl() path.
Fixes: #3354
make testwith your changes locally?