Conversation
Signed-off-by: 안민기 <ancrs0527@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make testwith your changes locally? (The full suite could not run locally because GTest, CUnit, and microsocks were unavailable; the focused password tests and sanitizer checks passed.)pw__encode_sha512()andpw__encode_sha512_pbkdf2()leave their temporary Base64 buffers allocated on some allocation-failure paths. The SHA-512 path also leaves the encoded salt allocated when encoding the password hash fails.Free the temporary buffers before returning from those paths. Successful password encoding is unchanged.
Validation:
test/apps/passwd/passwd-args.py,passwd-stdout.py, andpasswd-changes.py.This bug fix is based on the
fixesbranch.